Adding documentation around building the project #653
Conversation
LalatenduMohanty
force-pushed
the
build_docs
branch
from
740cb64 to
b1aee9f
Compare
pyproject.toml
Outdated
| [tool.hatch.envs.test] | ||
| features = ["test"] | ||
| # {args:tests} allows passing arguments to specify which tests to run | ||
| [[tool.hatch.envs.test.matrix]] |
There was a problem hiding this comment.
This change doesn't look related to the documentation update.
There was a problem hiding this comment.
It was causing the hatch build command to fail as multiple python versions are part of the default environment
$ hatch build
Unknown environment: default
There was a problem hiding this comment.
What happens when you run hatch run test:test now?
There was a problem hiding this comment.
It runs the test for each python version mentioned in test.matrix
There was a problem hiding this comment.
What is it doing in our CI jobs, since those are python version-specific?
I suspect we want to remove the python version matrix from the default env, instead of adding it here.
There was a problem hiding this comment.
That is something crossed my mind as well. Let me check that and get back here.
There was a problem hiding this comment.
I have removed the python version matrix. We should be good to merge this now.
LalatenduMohanty
force-pushed
the
build_docs
branch
3 times, most recently
from
cd8fb05 to
1f45467
Compare
Fixes python-wheel-build#652 Modified the pyproject.toml as it was causing teh hatch build command to fail as multiple python versions were part of the default environment. Also the matrix belongs on specific environments (like test) where multi-version behavior is actually needed, not on the default environment which should be simple and predictable. Signed-off-by: Lalatendu Mohanty <lmohanty@redhat.com>
2 participants
Fixes #652
Modified the pyproject.toml as it was causing teh hatch build command to fail
as multiple python versions were part of the default environment.
Also the matrix belongs on specific environments (like test) where multi-version
behavior is actually needed, not on the default environment which should be
simple and predictable.