Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Label a PR before posting the blurb help comment #492

Merged
merged 1 commit into from
Aug 5, 2022
Merged

Label a PR before posting the blurb help comment #492

merged 1 commit into from
Aug 5, 2022

Conversation

DanielNoord
Copy link
Contributor

Follow up to #485

python/cpython#94828 shows the previous PR works: changes to documentation are correctly labeled as skip news.
However, we're doing the check for the blurb_it help comment before we do the labeling.

This makes it so that we don't check whether we need to post that comment if we are going to label a PR as skip news.

/CC @ezio-melotti

@codecov
Copy link

codecov bot commented Jul 14, 2022

Codecov Report

Merging #492 (a496aea) into main (8e5ceb2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #492   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines         1826      1829    +3     
  Branches       222       223    +1     
=========================================
+ Hits          1826      1829    +3     
Flag Coverage Δ
Python_3.10 100.00% <100.00%> (ø)
Python_3.11-dev 100.00% <100.00%> (ø)
Python_3.8 100.00% <100.00%> (ø)
Python_3.9 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
bedevere/filepaths.py 100.00% <100.00%> (ø)
bedevere/prtype.py 100.00% <100.00%> (ø)
tests/test_filepaths.py 100.00% <100.00%> (ø)

@ezio-melotti ezio-melotti merged commit 428290e into python:main Aug 5, 2022
@DanielNoord DanielNoord deleted the news-order branch August 7, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants