Add additional pointers to pathlib's mapping to os.path functions #94828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Please add it using the blurb_it web app or the blurb command-line tool. |
This was referenced Jul 14, 2022
|
/cc @barneygale |
os.path.splitext has a somewhat quirky signature since it mixes the path and filename components but I wanted the documentation to mention `PurePath.stem` as the natural counterpart to `PurePath.suffix` for the common use of `os.path.splitext` to turn "file.py" into "file" and "py". Technically this could have some discussion of how to handle the parent directory hierarchy but that seems a bit out of keeping with the spirit of this table so I omitted mentioning `PurePath.parents` here.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
ezio-melotti
approved these changes
Jul 15, 2022
ezio-melotti
added
needs backport to 3.10
|
Thanks @acdha for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
|
GH-94889 is a backport of this pull request to the 3.11 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2022
…thonGH-94828) * Add additional pointers to pathlib's mapping to os.path functions os.path.splitext has a somewhat quirky signature since it mixes the path and filename components but I wanted the documentation to mention `PurePath.stem` as the natural counterpart to `PurePath.suffix` for the common use of `os.path.splitext` to turn "file.py" into "file" and "py". Technically this could have some discussion of how to handle the parent directory hierarchy but that seems a bit out of keeping with the spirit of this table so I omitted mentioning `PurePath.parents` here. * Update Doc/library/pathlib.rst Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 3789c63) Co-authored-by: Chris Adams <chris@improbable.org>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 15, 2022
…thonGH-94828) * Add additional pointers to pathlib's mapping to os.path functions os.path.splitext has a somewhat quirky signature since it mixes the path and filename components but I wanted the documentation to mention `PurePath.stem` as the natural counterpart to `PurePath.suffix` for the common use of `os.path.splitext` to turn "file.py" into "file" and "py". Technically this could have some discussion of how to handle the parent directory hierarchy but that seems a bit out of keeping with the spirit of this table so I omitted mentioning `PurePath.parents` here. * Update Doc/library/pathlib.rst Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 3789c63) Co-authored-by: Chris Adams <chris@improbable.org>
|
GH-94890 is a backport of this pull request to the 3.10 branch. |
miss-islington
added a commit
that referenced
this pull request
Jul 15, 2022
…-94828) * Add additional pointers to pathlib's mapping to os.path functions os.path.splitext has a somewhat quirky signature since it mixes the path and filename components but I wanted the documentation to mention `PurePath.stem` as the natural counterpart to `PurePath.suffix` for the common use of `os.path.splitext` to turn "file.py" into "file" and "py". Technically this could have some discussion of how to handle the parent directory hierarchy but that seems a bit out of keeping with the spirit of this table so I omitted mentioning `PurePath.parents` here. * Update Doc/library/pathlib.rst Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 3789c63) Co-authored-by: Chris Adams <chris@improbable.org>
miss-islington
added a commit
that referenced
this pull request
Jul 15, 2022
…-94828) * Add additional pointers to pathlib's mapping to os.path functions os.path.splitext has a somewhat quirky signature since it mixes the path and filename components but I wanted the documentation to mention `PurePath.stem` as the natural counterpart to `PurePath.suffix` for the common use of `os.path.splitext` to turn "file.py" into "file" and "py". Technically this could have some discussion of how to handle the parent directory hierarchy but that seems a bit out of keeping with the spirit of this table so I omitted mentioning `PurePath.parents` here. * Update Doc/library/pathlib.rst Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com> (cherry picked from commit 3789c63) Co-authored-by: Chris Adams <chris@improbable.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.path.splitext has a somewhat quirky signature since it mixes the path and filename components but I wanted the documentation to mention
PurePath.stemas the natural counterpart toPurePath.suffixfor the common use ofos.path.splitextto turn "file.py" into "file" and "py".Technically this could have some discussion of how to handle the parent directory hierarchy but that seems a bit out of keeping with the spirit of this table so I omitted mentioning
PurePath.parentshere.