Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some usages of sys.exc_info can be replaced by more modern code #102799

Closed
iritkatriel opened this issue Mar 17, 2023 · 1 comment
Closed

some usages of sys.exc_info can be replaced by more modern code #102799

iritkatriel opened this issue Mar 17, 2023 · 1 comment
Assignees
@iritkatriel
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Mar 17, 2023 •
edited by bedevere-bot
Loading

There are some obvious places where sys.exc_info() can be replaced by direct access to a captured exception (without needing any new features that could complicate backports.)

Need to avoid changing tests that are testing exc_info, like generator tests or sys.

Linked PRs
@iritkatriel iritkatriel added type-feature A feature request or enhancement stdlib Python modules in the Lib dir labels Mar 17, 2023
@iritkatriel iritkatriel self-assigned this Mar 17, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 17, 2023
@iritkatriel
pythongh-102799: remove unnecessary calls to sys.exc_info() in tests
1952868
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 17, 2023
@iritkatriel
pythongh-102799: remove unnecessary calls to sys.exc_info() in tests
fa3f31b
@bedevere-bot bedevere-bot mentioned this issue Mar 17, 2023
Merged
iritkatriel added a commit that referenced this issue Mar 18, 2023
@iritkatriel
gh-102799: remove unnecessary calls to sys.exc_info() in tests (#102800)
b3cc11a
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 19, 2023
@iritkatriel
pythongh-102799: pydoc doesn't need to use sys.exc_info
db6a8a9
@bedevere-bot bedevere-bot mentioned this issue Mar 19, 2023
Merged
iritkatriel added a commit that referenced this issue Mar 21, 2023
@iritkatriel
gh-102799: Let pydoc use the exception instead of sys.exc_info (#102830)
868490e
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Mar 21, 2023
@iritkatriel
pythongh-102799: use exception instance instead of exc_info
720a696
@bedevere-bot bedevere-bot mentioned this issue Mar 21, 2023
Merged
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102799: remove unnecessary calls to sys.exc_info() in tests (p…
e2e5fa6 
…ython#102800)
Fidget-Spinner pushed a commit to Fidget-Spinner/cpython that referenced this issue Mar 27, 2023
@iritkatriel @Fidget-Spinner
pythongh-102799: Let pydoc use the exception instead of sys.exc_info (p…
52172d3 
…ython#102830)
iritkatriel added a commit that referenced this issue Mar 31, 2023
@iritkatriel
gh-102799: use exception instance instead of sys.exc_info() (#102885)
44bd3fe
@iritkatriel iritkatriel reopened this Apr 5, 2023
@iritkatriel
Copy link
Member Author

Now that 3.10 is out of bugfix mode, we can use sys.exception() (which exists since 3.11, so would not cause issues with normal bugfix backports).

@bedevere-bot bedevere-bot mentioned this issue Apr 5, 2023
Merged
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Apr 5, 2023
@iritkatriel
pythongh-102799: use sys.exception() instead of sys.exc_info() in pdb
ada8557
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Apr 5, 2023
@iritkatriel
pythongh-102799: use sys.exception() instead of sys.exc_info() in pdb
09e3f5b
@bedevere-bot bedevere-bot mentioned this issue Apr 5, 2023
Merged
iritkatriel added a commit that referenced this issue Apr 6, 2023
@iritkatriel
gh-102799: use sys.exception() instead of sys.exc_info() in tests (#1…
482b6ee 
…03293)
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Apr 6, 2023
@iritkatriel
pythongh-102799: use sys.exception() instead of sys.exc_info() in con…
ede88da 
…textlib
@bedevere-bot bedevere-bot mentioned this issue Apr 6, 2023
Merged
kumaraditya303 pushed a commit that referenced this issue Apr 9, 2023
@iritkatriel
gh-102799: use sys.exception() instead of sys.exc_info() in pdb (#…
264b87f 
…103294)
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102799: remove unnecessary calls to sys.exc_info() in tests (p…
f624ea4 
…ython#102800)
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102799: Let pydoc use the exception instead of sys.exc_info (p…
9a62a94 
…ython#102830)
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102799: use exception instance instead of sys.exc_info() (py…
2f7d16a 
…thon#102885)
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102799: use sys.exception() instead of sys.exc_info() in tes…
0888a42 
…ts (python#103293)
warsaw pushed a commit to warsaw/cpython that referenced this issue Apr 11, 2023
@iritkatriel @warsaw
pythongh-102799: use sys.exception() instead of sys.exc_info() in…
34379b3 
… pdb (python#103294)
iritkatriel added a commit to iritkatriel/cpython that referenced this issue May 1, 2023
@iritkatriel
pythongh-102799: replace sys.exc_info by sys.exception in inspect and…
e77f883 
… traceback modules
@bedevere-bot bedevere-bot mentioned this issue May 1, 2023
Merged
iritkatriel added a commit that referenced this issue May 1, 2023
@iritkatriel
gh-102799: replace sys.exc_info by sys.exception in inspect and trace…
a679c3d 
…back modules (#104032)
carljm added a commit to carljm/cpython that referenced this issue May 1, 2023
@carljm
Merge branch 'main' into inlinecomp2
1274e2b 
* main: (463 commits)
  pythongh-104057: Fix direct invocation of test_super (python#104064)
  pythongh-87092: Expose assembler to unit tests (python#103988)
  pythongh-97696: asyncio eager tasks factory (python#102853)
  pythongh-84436: Immortalize in _PyStructSequence_InitBuiltinWithFlags() (pythongh-104054)
  pythongh-104057: Fix direct invocation of test_module (pythonGH-104059)
  pythongh-100458: Clarify Enum.__format__() change of mixed-in types in the whatsnew/3.11.rst (pythonGH-100387)
  pythongh-104018: disallow "z" format specifier in %-format of byte strings (pythonGH-104033)
  pythongh-104016: Fixed off by 1 error in f string tokenizer (python#104047)
  pythonGH-103629: Update Unpack's repr in compliance with PEP 692 (python#104048)
  pythongh-102799: replace sys.exc_info by sys.exception in inspect and traceback modules (python#104032)
  Fix typo in "expected" word in few source files (python#104034)
  pythongh-103824: fix use-after-free error in Parser/tokenizer.c (python#103993)
  pythongh-104035: Do not ignore user-defined `__{get,set}state__` in slotted frozen dataclasses (python#104041)
  pythongh-104028: Reduce object creation while calling callback function from gc (pythongh-104030)
  pythongh-104036: Fix direct invocation of test_typing (python#104037)
  pythongh-102213: Optimize the performance of `__getattr__` (pythonGH-103761)
  pythongh-103895: Improve how invalid `Exception.__notes__` are displayed (python#103897)
  Adjust expression from `==` to `!=` in alignment with the meaning of the paragraph. (pythonGH-104021)
  pythongh-88496: Fix IDLE test hang on macOS (python#104025)
  Improve int test coverage (python#104024)
  ...
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Jul 14, 2023
@iritkatriel
pythongh-102799: replace internal sys.exc_info() call by sys.exception()
f3c1848
@bedevere-bot bedevere-bot mentioned this issue Jul 14, 2023
Merged
iritkatriel added a commit that referenced this issue Jul 14, 2023
@iritkatriel
gh-102799: replace internal sys.exc_info() call by sys.exception() (#…
fb32f35 
…106746)
kumaraditya303 added a commit that referenced this issue Jul 20, 2023
@iritkatriel @kumaraditya303
gh-102799: use sys.exception() instead of sys.exc_info() in contextlib (
eeff8e7 
#103311)

Co-authored-by: Kumar Aditya <kumaraditya@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iritkatriel