Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update installers to Tcl/Tk 8.6.14 #116145

Closed
chrstphrchvz opened this issue Feb 29, 2024 · 13 comments
Closed

Update installers to Tcl/Tk 8.6.14 #116145

chrstphrchvz opened this issue Feb 29, 2024 · 13 comments
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes

Comments

@chrstphrchvz
Copy link
Contributor

chrstphrchvz commented Feb 29, 2024

Tcl/Tk 8.6.14 is out today: https://sourceforge.net/p/tcl/mailman/tcl-core/thread/SA1PR09MB887585E09B30AE57F0E7F2E3865F2%40SA1PR09MB8875.namprd09.prod.outlook.com/#msg58743251

I will open a few PRs for these shortly: one here for the macOS installer, and others at cpython-source-deps for Windows:
python/cpython-source-deps#33
python/cpython-source-deps#34

There is still a known test failure with Tk 8.6.14 which I have neglected: gh-107262

Linked PRs

@hugovk
Copy link
Member

hugovk commented Mar 15, 2024

The linked PR is merged, is there more to do or can this issue be closed? Thanks!

@ned-deily
Copy link
Member

The linked PR is merged, is there more to do or can this issue be closed? Thanks!

I believe the Windows build needs to be updated to use the new version (PCbuild/get_externals.bat and PCbuild/tcltk.props). @zooba @zware

@zooba
Copy link
Member

zooba commented Mar 19, 2024

Yeah, Windows is not done yet. I should have time later today to bring in the new sources and set the build up.

@zooba
Copy link
Member

zooba commented Mar 19, 2024

It looks like something has changed in Tkinter as a result of the new version. @terryjreedy is this something you can look into? You can see the build results on #117030

serhiy-storchaka added a commit to zooba/cpython that referenced this issue May 30, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 31, 2024
…H-117030)

(cherry picked from commit 0e8d35b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@serhiy-storchaka serhiy-storchaka added 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels May 31, 2024
zooba added a commit that referenced this issue May 31, 2024
(cherry picked from commit 0e8d35b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@terryjreedy
Copy link
Member

@zooba I have no record or recollection of receiving your Mar 20 note. I just read the release announcement and don't see any problem at least with IDLE. I will do some manual testing after updating. Glad to see update in both 3.13 and 3.14. Fine to leave 3.12 alone.

@serhiy-storchaka
Copy link
Member

8.6.14 is a bugfix release, and it can contain changes affecting Tkinter users. https://wiki.tcl-lang.org/page/Changes+in+Tcl%2FTk+8%2E6%2E14

Is there a way for Windows and macOS users to update Tcl/Tk separately? If they can only use the version shipped with Python, we should provide the last stable bugfix release.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 1, 2024
…6151)

(cherry picked from commit 4fa95c6)

Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@ned-deily
Copy link
Member

If they can only use the version shipped with Python, we should provide the last stable bugfix release.

Thanks for the reminder, @serhiy-storchaka. This should have been backported earlier to 3.12.x for the macOS installer but I guess I was waiting to see if any issues arose with the 3.13 alphas. PR #119922 will be merged for the upcoming 3.12.4 release.

ned-deily pushed a commit that referenced this issue Jun 1, 2024
…GH-119922)

(cherry picked from commit 4fa95c6)
Co-authored-by: Christopher Chavez <chrischavez@gmx.us>
@aivarannamaa
Copy link
Contributor

The discussion under PR-s is confusing for me, so I'll ask here -- is Tcl/Tk 8.6.14 coming for Python 3.12 Windows installers? 3.12.4 seems to be still with 8.6.13.

serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this issue Jun 12, 2024
…ythonGH-117030)

(cherry picked from commit 0e8d35b)

Co-authored-by: Steve Dower <steve.dower@python.org>
@marcelotduarte
Copy link

marcelotduarte commented Aug 6, 2024

There is an error in tkinter.Tk()

$ python
Python 3.13.0rc1 (tags/v3.13.0rc1:e4a3e78, Jul 31 2024, 20:58:38) [MSC v.1940 64 bit (AMD64)] on win32
Type "help", "copyright", "credits" or "license" for more information.
>>> import tkinter
>>> tkinter.TkVersion
8.6
>>> tkinter.TclVersion
8.6
>>> tkinter.Tk()
Traceback (most recent call last):
  File "<python-input-7>", line 1, in <module>
    tkinter.Tk()
    ~~~~~~~~~~^^
  File "C:\Python313-64\Lib\tkinter\__init__.py", line 2459, in __init__
    self.tk = _tkinter.create(screenName, baseName, className, interactive, wantobjects, useTk, sync, use)
              ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
_tkinter.TclError: Can't find a usable init.tcl in the following directories:
    C:/Python313-64/lib/tcl8.6 C:/lib/tcl8.6 C:/lib/tcl8.6 C:/library C:/library C:/tcl8.6.14/library C:/tcl8.6.14/library



This probably means that Tcl wasn't installed properly.

The correct path to search is C:/Python313-64/tcl/tcl8.6. In python 3.12.4 is C:/Python312-64/tcl/tcl8.6 also.

@terryjreedy
Copy link
Member

Same binary, some Python commands, Win10, works fine for me.

>>> import tkinter
>>> tkinter.Tk()
<tkinter.Tk object .>

No idea why the difference.

@terryjreedy
Copy link
Member

IDLE works normally and reports 8.6.14, as expected.

@marcelotduarte
Copy link

marcelotduarte commented Aug 7, 2024

I experienced this error using GHA for testing cx_Freeze.
So I installed it in a VM with W11 to test.
The difference may be that I didn't install python for all users, like GH.
The error in GHA:

File "C:\Users\runneradmin\.local\venv\cxfreeze_tkinter_win-amd64_313\Lib\site-packages\cx_Freeze\hooks\tkinter.py", line 35, in load_tkinter
      root = tkinter.Tk(useTk=False)
    File "C:\hostedtoolcache\windows\Python\3.13.0-rc.1\x64\Lib\tkinter\__init__.py", line 2459, in __init__
      self.tk = _tkinter.create(screenName, baseName, className, interactive, wantobjects, useTk, sync, use)
                ~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  _tkinter.TclError: Can't find a usable init.tcl in the following directories: 
      C:/hostedtoolcache/windows/Python/3.13.0-rc.1/x64/lib/tcl8.6 C:/hostedtoolcache/windows/Python/3.13.0-rc.1/lib/tcl8.6 C:/hostedtoolcache/windows/Python/lib/tcl8.6 C:/hostedtoolcache/windows/Python/3.13.0-rc.1/library C:/hostedtoolcache/windows/Python/library C:/hostedtoolcache/windows/Python/tcl8.6.14/library C:/hostedtoolcache/windows/tcl8.6.14/library
  
  
  
  This probably means that Tcl wasn't installed properly.

@zware
Copy link
Member

zware commented Oct 21, 2024

I'm going to go ahead and mark this as complete. For posterity, v3.13.0 shipped with Tcl/Tk v8.6.14 on Windows and macOS; v3.12.4-v3.12.7 have Tcl/Tk v8.6.14 on macOS and v8.6.13 on Windows. v3.13.1 and v3.12.8 will have Tcl/Tk v8.6.15 on both platforms; v3.12.8 will have Tix v8.4.3 as built against Tcl/Tk v8.6.13 on Windows.

@zware zware closed this as completed Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes
Projects
None yet
Development

No branches or pull requests

9 participants