-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.12] gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 (GH-117030) #120396
[3.12] gh-116145: Updated bundled Tcl/Tk on Windows to 8.6.14 (GH-117030) #120396
Conversation
…ythonGH-117030) (cherry picked from commit 0e8d35b) Co-authored-by: Steve Dower <steve.dower@python.org>
https://github.com/python/cpython-source-deps/archive/refs/tags/tix-8.4.3.6.tar.gz does not exist. But this reference is not changed in this PR! |
It exists. The problem must be anywhere else. |
It looks to me like Tix compatibility finally broke in Tcl/Tk 8.6.14. I don't think it's worthwhile to try to fix Tix (which is removed from Python 3.13+ and deprecated in 3.6-3.12); I'll leave it up to your judgement whether to disable the test or skip the Tcl/Tk update on 3.12. |
Oh, wait. I think it's because our 8.6.14 binary package doesn't include Tix. I'm still not sure it's worthwhile to fix. |
I'm somewhat out of the loop here; how impactful is the update to Tcl/Tk 8.6.14 on Windows? Is it worth @zooba's time creating a |
There are plentiful of changes in 8.6.14 in comparison with previous bugfixes. |
Do we need to create it or can we just copy it into the latest branch (and update the tag)? |
The main problem is that we need to build Tix for it. |
Tix has no dependencies, so it should be fine with the last built one. I can copy it into our 8.6.14 build and tag a new .1 version, or would you prefer 8.6.15? |
I think it may be easier to go right to 8.6.15. |
Okay, there's an 8.6.15.1 available now that has the Tix libs added. No other changes, so no need to update newer versions. |
(cherry picked from commit 0e8d35b)