Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Py_DECREF for load_build in _pickle.c #126991

Closed
Legoclones opened this issue Nov 19, 2024 · 1 comment
Closed

Missing Py_DECREF for load_build in _pickle.c #126991

Legoclones opened this issue Nov 19, 2024 · 1 comment
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@Legoclones
Copy link
Contributor

Legoclones commented Nov 19, 2024 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

In the load_build function of Modules/_pickle.c, if setting a value in a dictionary fails, the dict variable does not have its reference counter decreased.

Pull request was made at #126990

CPython versions tested on:

3.11

Operating systems tested on:

Linux

Linked PRs
@Legoclones Legoclones added the type-bug An unexpected behavior, bug, or error label Nov 19, 2024
@Legoclones Legoclones mentioned this issue Nov 19, 2024
Merged
@ZeroIntensity ZeroIntensity added extension-modules C modules in the Modules dir 3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes labels Nov 19, 2024
serhiy-storchaka pushed a commit that referenced this issue Nov 19, 2024
@Legoclones
gh-126991: Fix reference leak in loading pickle's opcode BUILD (GH-12…
29cbcbd 
…6990)

If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 19, 2024
@Legoclones @miss-islington
pythongh-126991: Fix reference leak in loading pickle's opcode BUILD (p…
a7fcefd 
…ythonGH-126990)

If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable.
(cherry picked from commit 29cbcbd)

Co-authored-by: Justin Applegate <70449145+Legoclones@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 19, 2024
@Legoclones @miss-islington
pythongh-126991: Fix reference leak in loading pickle's opcode BUILD (p…
fc39bfb 
…ythonGH-126990)

If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable.
(cherry picked from commit 29cbcbd)

Co-authored-by: Justin Applegate <70449145+Legoclones@users.noreply.github.com>
This was referenced Nov 19, 2024
Merged
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 19, 2024
@serhiy-storchaka
pythongh-126991: Add tests for unpickling bad object state
dd16b0a 
This catches a memory leak in loading the BUILD opcode.
@colesbury colesbury changed the title Missing PyDECREF for load_build in _pickle.c Missing Py_DECREF for load_build in _pickle.c Nov 19, 2024
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 19, 2024
@serhiy-storchaka
pythongh-126991: Add tests for unpickling bad object state
80a8275 
This catches a memory leak in loading the BUILD opcode.
@bedevere-app bedevere-app bot mentioned this issue Nov 19, 2024
Merged
serhiy-storchaka pushed a commit that referenced this issue Nov 19, 2024
@miss-islington @Legoclones
[3.12] gh-126991: Fix reference leak in loading pickle's opcode BUILD (…
153221a 
…GH-126990) (GH-127019)

If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable.
(cherry picked from commit 29cbcbd)

Co-authored-by: Justin Applegate <70449145+Legoclones@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this issue Nov 19, 2024
@miss-islington @Legoclones
[3.13] gh-126991: Fix reference leak in loading pickle's opcode BUILD (…
bb98a0a 
…GH-126990) (GH-127018)

If PyObject_SetItem() fails in the `load_build()` function of _pickle.c, no DECREF for the `dict` variable.
(cherry picked from commit 29cbcbd)

Co-authored-by: Justin Applegate <70449145+Legoclones@users.noreply.github.com>
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @Legoclones. #127031 adds a test for this leak, as well as coverage tests for other corner cases.

serhiy-storchaka added a commit that referenced this issue Nov 20, 2024
@serhiy-storchaka
gh-126991: Add tests for unpickling bad object state (GH-127031)
addb225 
This catches a memory leak in loading the BUILD opcode.
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 20, 2024
@serhiy-storchaka @miss-islington
pythongh-126991: Add tests for unpickling bad object state (pythonGH-…
f8bb55a 
…127031)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Nov 20, 2024
@serhiy-storchaka @miss-islington
pythongh-126991: Add tests for unpickling bad object state (pythonGH-…
60055d0 
…127031)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
This was referenced Nov 20, 2024
Merged
Merged
serhiy-storchaka added a commit that referenced this issue Nov 20, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-126991: Add tests for unpickling bad object state (GH-127031)…
b33c37a 
… (GH-127064)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this issue Nov 24, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-126991: Add tests for unpickling bad object state (GH-127031)…
69472a5 
… (GH-127063)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 bugs and security fixes 3.13 bugs and security fixes 3.14 new features, bugs and security fixes extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@serhiy-storchaka @ZeroIntensity @Legoclones