Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126991: Add tests for unpickling bad object state #127031

Merged
merged 1 commit into from
Nov 20, 2024
Merged

gh-126991: Add tests for unpickling bad object state #127031

merged 1 commit into from
Nov 20, 2024

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Nov 19, 2024 •
edited by bedevere-app bot
Loading

This catches a memory leak in loading the BUILD opcode.

@serhiy-storchaka
pythongh-126991: Add tests for unpickling bad object state
80a8275 
This catches a memory leak in loading the BUILD opcode.
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Nov 19, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 19, 2024
Closed
gpshead
gpshead approved these changes Nov 19, 2024
View reviewed changes
Copy link
Member

@gpshead gpshead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not like I know pickle protocol internals well enough to read the bits of pickle in the tests, but they're small and I trust that you now do. :)

@serhiy-storchaka serhiy-storchaka merged commit addb225 into python:main Nov 20, 2024
48 checks passed
@miss-islington-app
Copy link

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the pickle-test-bad-state branch November 20, 2024 15:31
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2024
@serhiy-storchaka @miss-islington
pythongh-126991: Add tests for unpickling bad object state (pythonGH-…
f8bb55a 
…127031)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 20, 2024
@serhiy-storchaka @miss-islington
pythongh-126991: Add tests for unpickling bad object state (pythonGH-…
60055d0 
…127031)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2024

GH-127063 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 20, 2024
@bedevere-app
Copy link

bedevere-app bot commented Nov 20, 2024

GH-127064 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 20, 2024
serhiy-storchaka added a commit that referenced this pull request Nov 20, 2024
@miss-islington @serhiy-storchaka
[3.12] gh-126991: Add tests for unpickling bad object state (GH-127031)…
b33c37a 
… (GH-127064)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Nov 24, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-126991: Add tests for unpickling bad object state (GH-127031)…
69472a5 
… (GH-127063)

This catches a memory leak in loading the BUILD opcode.
(cherry picked from commit addb225)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead gpshead approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @gpshead