Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gettext Make target replaces SPHINXOPTS from command line #127356

Closed
rffontenelle opened this issue Nov 28, 2024 · 0 comments
Closed

gettext Make target replaces SPHINXOPTS from command line #127356

rffontenelle opened this issue Nov 28, 2024 · 0 comments
Labels
build The build process and cross-build docs Documentation in the Doc dir

Comments

@rffontenelle
Copy link
Contributor

rffontenelle commented Nov 28, 2024 •
edited by bedevere-app bot
Loading

Documentation

Running make gettext will override any value provided in SPHINXOPTS. The Makefile currently has gettext: SPHINXOPTS += -d build/doctrees-gettext since fb0cf7d (edited with 315a933) and it doesn't append such value, but replaces instead.

Steps to reproduce (from Doc folder):

  1. make gettext # See '-d build/doctrees-gettext' added to command line
  2. make gettext SPHINXOPTS='-q' # See '-q' ignored, and '-d build/doctrees-gettext' added to command line

Linked PRs
@rffontenelle rffontenelle added the docs Documentation in the Doc dir label Nov 28, 2024
@bedevere-app bedevere-app bot mentioned this issue Nov 28, 2024
Merged
@ZeroIntensity ZeroIntensity added the build The build process and cross-build label Nov 28, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
hugovk pushed a commit that referenced this issue Dec 1, 2024
@rffontenelle
gh-127356: Fix prepend doctrees directory for gettext target (#127357)
a880358
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 1, 2024
@rffontenelle @miss-islington
pythongh-127356: Fix prepend doctrees directory for gettext target (p…
9bc26d5 
…ythonGH-127357)

(cherry picked from commit a880358)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Dec 1, 2024
@rffontenelle @miss-islington
pythongh-127356: Fix prepend doctrees directory for gettext target (p…
cc389b2 
…ythonGH-127357)

(cherry picked from commit a880358)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
This was referenced Dec 1, 2024
Merged
Merged
@hugovk hugovk closed this as completed Dec 1, 2024
hugovk pushed a commit that referenced this issue Dec 1, 2024
@miss-islington @rffontenelle
[3.13] gh-127356: Fix prepend doctrees directory for gettext target (G…
3b31f8c 
…H-127357) (#127470)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
hugovk pushed a commit that referenced this issue Dec 1, 2024
@miss-islington @rffontenelle
[3.12] gh-127356: Fix prepend doctrees directory for gettext target (G…
87b7122 
…H-127357) (#127471)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 2, 2024
@rffontenelle @picnixz
pythongh-127356: Fix prepend doctrees directory for gettext target (p…
c6193a8 
…ython#127357)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build docs Documentation in the Doc dir
Projects
docs issues
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hugovk @rffontenelle @ZeroIntensity