Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-127356: Fix prepend doctrees directory for gettext target #127357

Merged
merged 1 commit into from
Dec 1, 2024

Conversation

rffontenelle
Copy link
Contributor

@rffontenelle rffontenelle commented Nov 28, 2024

This allows SPHINXOPTS be passed via command-line for gettext target, and puts the -d doctree-gettext value before any SPHINXOPTS passed, hence allowing that value to be replaced if wanted.


📚 Documentation preview 📚: https://cpython-previews--127357.org.readthedocs.build/

@hugovk hugovk added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes skip news labels Nov 28, 2024
@hugovk hugovk merged commit a880358 into python:main Dec 1, 2024
34 checks passed
@miss-islington-app
Copy link

Thanks @rffontenelle for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@hugovk
Copy link
Member

hugovk commented Dec 1, 2024

Thank you!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2024
…ythonGH-127357)

(cherry picked from commit a880358)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 1, 2024
…ythonGH-127357)

(cherry picked from commit a880358)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Dec 1, 2024

GH-127470 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Dec 1, 2024
@bedevere-app
Copy link

bedevere-app bot commented Dec 1, 2024

GH-127471 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Dec 1, 2024
hugovk pushed a commit that referenced this pull request Dec 1, 2024
…H-127357) (#127470)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
hugovk pushed a commit that referenced this pull request Dec 1, 2024
…H-127357) (#127471)

Co-authored-by: Rafael Fontenelle <rffontenelle@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants