Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pipe test failures on some Linux configurations #95672

Closed
colesbury opened this issue Aug 4, 2022 · 3 comments
Closed

pipe test failures on some Linux configurations #95672

colesbury opened this issue Aug 4, 2022 · 3 comments
Assignees
@corona10 @hyeongyun0916
Labels
3.10 only security fixes 3.11 only security fixes 3.12 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Aug 4, 2022 •
edited by bedevere-bot
Loading

Bug report

On Linux systems, when configured with a default pipe capacity of 4096, the following test fail:

  • test_fcntl.test_fcntl_f_pipesize
  • test_subprocess.test_pipesizes

From a recent fcntl(2) Linux man page:

F_SETPIPE_SZ:
...
Attempts to set the pipe capacity below the page size are silently rounded up to the page size.

There's a check that attempts to skip the tests if the pipe capacity is 512 bytes, but that's less than the smallest page size on x86.

Since this feature appears to be Linux specific, the check should:

  1. Use os.sysconf('SC_PAGESIZE') as a minimum
  2. Fix the typos ("SkitTest") in test_fcntl_f_pipesize and test_pipesizes

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir 3.11 only security fixes 3.10 only security fixes 3.12 bugs and security fixes labels Aug 4, 2022
@corona10 corona10 self-assigned this Feb 18, 2023
@corona10
Copy link
Member

corona10 commented Feb 18, 2023 •
edited
Loading

Same as #95675 (comment)
I will introduce this issue into the internal OSS sprint as the good first bug.
I will delegate the issue to my mentees.
Thank you for understanding!

@hyeongyun0916
Copy link
Contributor

I'm looking this issue 👀

This was referenced Feb 21, 2023
Merged
Open
This was referenced Feb 21, 2023
Merged
Merged
corona10 pushed a commit that referenced this issue Feb 21, 2023
@hyeongyun0916
gh-95672 fix typo SkitTest to SkipTest (gh-102119)
d5c7954 
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 21, 2023
@hyeongyun0916 @miss-islington
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
bbe277e 
(cherry picked from commit d5c7954)

Co-authored-by: Hyunkyun Moon <mhg5303@gmail.com>
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Feb 21, 2023
@hyeongyun0916 @miss-islington
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
d3f8606 
(cherry picked from commit d5c7954)

Co-authored-by: Hyunkyun Moon <mhg5303@gmail.com>
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
corona10 pushed a commit that referenced this issue Feb 22, 2023
@miss-islington @hyeongyun0916
[3.11] gh-95672 fix typo SkitTest to SkipTest (gh-102119) (#102121)
5d47150 
gh-95672 fix typo SkitTest to SkipTest (gh-102119)
(cherry picked from commit d5c7954)

Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
corona10 pushed a commit that referenced this issue Feb 22, 2023
@miss-islington @hyeongyun0916
[3.10] gh-95672 fix typo SkitTest to SkipTest (gh-102119) (gh-102122)
bac3fe7 
gh-95672 fix typo SkitTest to SkipTest (gh-102119)
(cherry picked from commit d5c7954)

Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
carljm added a commit to carljm/cpython that referenced this issue Feb 23, 2023
@carljm
Merge branch 'main' into lockfreecp
b257a16 
* main: (76 commits)
  Fix syntax error in struct doc example (python#102160)
  pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)
  pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)
  Few coverage nitpicks for the cmath module (python#102067)
  pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)
  pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)
  pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)
  pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
  pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)
  pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)
  pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
  pythongh-100556: Improve clarity of `or` docs (python#100589)
  pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)
  pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)
  pythongh-101578: Amend exception docs (python#102057)
  pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  ...
@bedevere-bot bedevere-bot mentioned this issue Feb 23, 2023
Merged
corona10 pushed a commit that referenced this issue Mar 1, 2023
@hyeongyun0916
gh-95672 skip fcntl when pipesize is smaller than pagesize (gh-102163)
2f62a5d
@bedevere-bot bedevere-bot mentioned this issue Mar 2, 2023
Merged
corona10 pushed a commit that referenced this issue Mar 2, 2023
@hyeongyun0916
gh-95672: Update memory_watchdog to use test.support.get_pagesize (gh…
6059743 
…-102365)
@corona10
Copy link
Member

corona10 commented Mar 2, 2023

@hyeongyun0916 Thanks for the hardwork!

@corona10 corona10 closed this as completed Mar 2, 2023
@bedevere-bot bedevere-bot mentioned this issue Mar 6, 2023
Merged
corona10 pushed a commit that referenced this issue Mar 6, 2023
@hyeongyun0916
gh-95672: Fix versionadded indentation of get_pagesize in test.rst (g…
d3ca042 
…h-102455)
carljm added a commit to carljm/cpython that referenced this issue Mar 6, 2023
@carljm
Merge branch 'main' into nodeaddict
33dda2a 
* main: (21 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...
carljm added a commit to carljm/cpython that referenced this issue Mar 7, 2023
@carljm
Merge branch 'main' into inlinecomp2
ecb313c 
* main: (37 commits)
  pythongh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives in sub interpreters module (python#102472)
  pythongh-95672: Fix versionadded indentation of get_pagesize in test.rst (pythongh-102455)
  pythongh-102416: Do not memoize incorrectly loop rules in the parser (python#102467)
  pythonGH-101362: Optimise PurePath(PurePath(...)) (pythonGH-101667)
  pythonGH-101362: Check pathlib.Path flavour compatibility at import time (pythonGH-101664)
  pythonGH-101362: Call join() only when >1 argument supplied to pathlib.PurePath() (python#101665)
  pythongh-102444: Fix minor bugs in `test_typing` highlighted by pyflakes (python#102445)
  pythonGH-102341: Improve the test function for pow (python#102342)
  Fix unused classes in a typing test (pythonGH-102437)
  pythongh-101979: argparse: fix a bug where parentheses in metavar argument of add_argument() were dropped (python#102318)
  pythongh-102356: Add thrashcan macros to filter object dealloc (python#102426)
  Move around example in to_bytes() to avoid confusion (python#101595)
  pythonGH-97546: fix flaky asyncio `test_wait_for_race_condition` test (python#102421)
  pythongh-96821: Add config option `--with-strict-overflow` (python#96823)
  pythongh-101992: update pstlib module documentation (python#102133)
  pythongh-63301: Set exit code when tabnanny CLI exits on error (python#7699)
  pythongh-101863: Fix wrong comments in EUC-KR codec (pythongh-102417)
  pythongh-102302 Micro-optimize `inspect.Parameter.__hash__` (python#102303)
  pythongh-102179: Fix `os.dup2` error reporting for negative fds (python#102180)
  pythongh-101892: Fix `SystemError` when a callable iterator call exhausts the iterator (python#101896)
  ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this issue Sep 1, 2024
@hyeongyun0916 @python-sidebar
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
8ac8bdd 
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this issue Sep 1, 2024
@hyeongyun0916 @python-sidebar
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
da08f1d 
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this issue Sep 10, 2024
@hyeongyun0916 @JelleZijlstra
pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
065e45d 
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@corona10 corona10

@hyeongyun0916 hyeongyun0916

Labels
3.10 only security fixes 3.11 only security fixes 3.12 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colesbury @corona10 @hyeongyun0916