Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-95672 fix typo SkitTest to SkipTest #102119

Merged
merged 2 commits into from
Feb 21, 2023
Merged

Conversation

hyeongyun0916
Copy link
Contributor

@hyeongyun0916 hyeongyun0916 commented Feb 21, 2023

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Feb 21, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@corona10 corona10 self-assigned this Feb 21, 2023
@corona10 corona10 added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 21, 2023
@@ -0,0 +1,2 @@
Fix the typos ("SkitTest") in test_fcntl_f_pipesize and test_pipesizes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hyeongyun0916 We can skip the NEWS.d since the unit test does not affect to end-user usage :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll delete it

Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 merged commit d5c7954 into python:main Feb 21, 2023
@miss-islington
Copy link
Contributor

Thanks @hyeongyun0916 for the PR, and @corona10 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-102121 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 21, 2023
@bedevere-bot
Copy link

GH-102122 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2023
(cherry picked from commit d5c7954)

Co-authored-by: Hyunkyun Moon <mhg5303@gmail.com>
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2023
(cherry picked from commit d5c7954)

Co-authored-by: Hyunkyun Moon <mhg5303@gmail.com>
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
corona10 pushed a commit that referenced this pull request Feb 22, 2023
gh-95672 fix typo SkitTest to SkipTest (gh-102119)
(cherry picked from commit d5c7954)

Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
corona10 pushed a commit that referenced this pull request Feb 22, 2023
gh-95672 fix typo SkitTest to SkipTest (gh-102119)
(cherry picked from commit d5c7954)

Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
carljm added a commit to carljm/cpython that referenced this pull request Feb 23, 2023
* main: (76 commits)
  Fix syntax error in struct doc example (python#102160)
  pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)
  pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)
  Few coverage nitpicks for the cmath module (python#102067)
  pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)
  pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)
  pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)
  pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
  pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)
  pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)
  pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
  pythongh-100556: Improve clarity of `or` docs (python#100589)
  pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)
  pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)
  pythongh-101578: Amend exception docs (python#102057)
  pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  ...
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
Co-authored-by: HyunKyun Moon <hyunkyun.moon@linecorp.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants