Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() #102009

Merged
merged 3 commits into from
Feb 21, 2023
Merged

gh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() #102009

merged 3 commits into from
Feb 21, 2023

Conversation

iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Feb 17, 2023 •
edited by bedevere-bot
Loading

This test was added in 3.11 (along with sys.exception()) so this change won't cause any backporting issues.

@bedevere-bot bedevere-bot mentioned this pull request Feb 17, 2023
Closed
@bedevere-bot bedevere-bot added the tests Tests in the Lib/test dir label Feb 17, 2023
@iritkatriel iritkatriel changed the title gh-102008: simplify test_exception_star by using sys.exception() instead of sys.exc_info() gh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() Feb 18, 2023
@iritkatriel iritkatriel merged commit c2b85a9 into python:main Feb 21, 2023
@miss-islington
Copy link
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 21, 2023
@iritkatriel @miss-islington
pythongh-102008: simplify test_except_star by using sys.exception() i…
ebe9a40 
…nstead of sys.exc_info() (pythonGH-102009)

(cherry picked from commit c2b85a9)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@bedevere-bot
Copy link

GH-102116 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 21, 2023
miss-islington added a commit that referenced this pull request Feb 21, 2023
@miss-islington @iritkatriel
gh-102008: simplify test_except_star by using sys.exception() instead…
3bfa608 
… of sys.exc_info() (GH-102009)

(cherry picked from commit c2b85a9)

Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
carljm added a commit to carljm/cpython that referenced this pull request Feb 23, 2023
@carljm
Merge branch 'main' into lockfreecp
b257a16 
* main: (76 commits)
  Fix syntax error in struct doc example (python#102160)
  pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)
  pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)
  Few coverage nitpicks for the cmath module (python#102067)
  pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)
  pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)
  pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)
  pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
  pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)
  pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)
  pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
  pythongh-100556: Improve clarity of `or` docs (python#100589)
  pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)
  pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)
  pythongh-101578: Amend exception docs (python#102057)
  pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  ...
@iritkatriel iritkatriel deleted the update_tests branch April 3, 2023 17:45
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@iritkatriel @python-sidebar
pythongh-102008: simplify test_except_star by using sys.exception() i…
eefd275 
…nstead of sys.exc_info() (python#102009)
python-sidebar pushed a commit to python-sidebar/Python-Documentation-Fork-With-TOC that referenced this pull request Sep 1, 2024
@iritkatriel @python-sidebar
pythongh-102008: simplify test_except_star by using sys.exception() i…
5ecdace 
…nstead of sys.exc_info() (python#102009)
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@iritkatriel @JelleZijlstra
pythongh-102008: simplify test_except_star by using sys.exception() i…
4b997e8 
…nstead of sys.exc_info() (python#102009)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iritkatriel @miss-islington @bedevere-bot @erlend-aasland