Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-102137: Update turtle docs to rename wikipedia demo to rosette #102137

Merged
merged 1 commit into from
Feb 22, 2023
Merged

gh-102137: Update turtle docs to rename wikipedia demo to rosette #102137

merged 1 commit into from
Feb 22, 2023

Conversation

SectorCorruptor
Copy link
Contributor

@SectorCorruptor SectorCorruptor commented Feb 22, 2023

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Feb 22, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Feb 22, 2023
@SectorCorruptor SectorCorruptor changed the title Updated "wikipedia" title and changed its order gh-102135: Updated "wikipedia" title and changed its order Feb 22, 2023
@hugovk hugovk added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Feb 22, 2023
Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the issue and your PR!

@hugovk hugovk changed the title gh-102135: Updated "wikipedia" title and changed its order gh-102135: Update turtle docs to rename wikipedia demo to rosette Feb 22, 2023
@hugovk hugovk merged commit 8d46c7e into python:main Feb 22, 2023
@miss-islington
Copy link
Contributor

Thanks @UndoneStudios for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@SectorCorruptor SectorCorruptor deleted the patch-2 branch February 22, 2023 10:11
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2023
…te (pythonGH-102137)

(cherry picked from commit 8d46c7e)

Co-authored-by: somebody <98094921+UndoneStudios@users.noreply.github.com>
@bedevere-bot
Copy link

GH-102138 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Feb 22, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 22, 2023
…te (pythonGH-102137)

(cherry picked from commit 8d46c7e)

Co-authored-by: somebody <98094921+UndoneStudios@users.noreply.github.com>
@bedevere-bot
Copy link

GH-102139 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 22, 2023
@SectorCorruptor
Copy link
Contributor Author

Just one question: how long will it be before the docs update?

@hugovk
Copy link
Member

hugovk commented Feb 22, 2023

They update once per day, so it should be live tomorrow.

You can see the "Last updated on Feb 22, 2023" at the bottom of the page.

https://docs.python.org/3/library/turtle.html

hugovk pushed a commit that referenced this pull request Feb 22, 2023
…tte (GH-102137) (#102139)

Co-authored-by: somebody <98094921+UndoneStudios@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Feb 22, 2023
…tte (GH-102137) (GH-102138)

(cherry picked from commit 8d46c7e)

Co-authored-by: somebody <98094921+UndoneStudios@users.noreply.github.com>

Automerge-Triggered-By: GH:hugovk
@SectorCorruptor SectorCorruptor changed the title gh-102135: Update turtle docs to rename wikipedia demo to rosette gh-102137: Update turtle docs to rename wikipedia demo to rosette Feb 22, 2023
carljm added a commit to carljm/cpython that referenced this pull request Feb 23, 2023
* main: (76 commits)
  Fix syntax error in struct doc example (python#102160)
  pythongh-99108: Import MD5 and SHA1 from HACL* (python#102089)
  pythonGH-101777: `queue.rst`: use 2 spaces after a period to be consistent. (python#102143)
  Few coverage nitpicks for the cmath module (python#102067)
  pythonGH-100982: Restrict `FOR_ITER_RANGE` to a single instruction to allow instrumentation. (pythonGH-101985)
  pythongh-102135: Update turtle docs to rename wikipedia demo to rosette (python#102137)
  pythongh-99942: python.pc on android/cygwin should link to libpython per configure.ac (pythonGH-100356)
  pythongh-95672 fix typo SkitTest to SkipTest (pythongh-102119)
  pythongh-101936: Update the default value of fp from io.StringIO to io.BytesIO (pythongh-102100)
  pythongh-102008: simplify test_except_star by using sys.exception() instead of sys.exc_info() (python#102009)
  pythongh-101903: Remove obsolete undefs for previously removed macros Py_EnterRecursiveCall and Py_LeaveRecursiveCall (python#101923)
  pythongh-100556: Improve clarity of `or` docs (python#100589)
  pythongh-101777: Make `PriorityQueue` docs slightly clearer (python#102026)
  pythongh-101965: Fix usage of Py_EnterRecursiveCall return value in _bisectmodule.c (pythonGH-101966)
  pythongh-101578: Amend exception docs (python#102057)
  pythongh-101961 fileinput.hookcompressed should not set the encoding value for the binary mode (pythongh-102068)
  pythongh-102056: Fix a few bugs in error handling of exception printing code (python#102078)
  pythongh-102011: use sys.exception() instead of sys.exc_info() in docs where possible (python#102012)
  pythongh-101566: Sync with zipp 3.14. (pythonGH-102018)
  pythonGH-99818: improve the documentation for zipfile.Path and Traversable (pythonGH-101589)
  ...
@SectorCorruptor
Copy link
Contributor Author

They update once per day, so it should be live tomorrow.

You can see the "Last updated on Feb 22, 2023" at the bottom of the page.

https://docs.python.org/3/library/turtle.html

About the link you attached, it seems the update is on 3.12, not 3.11. Which I understand mainly as this GitHub repo is for 3.12, not 3.11.

@hugovk
Copy link
Member

hugovk commented Feb 23, 2023

This repo is for all versions, we use different branches for different versions. (More info about the branches at https://devguide.python.org/versions/)

After I merged your fix to main = 3.12, I also "backported" it to 3.11 and 3.10, so we can now see it on 3.10 ("Last updated on Feb 23, 2023") and 3.12 ("Last updated on Feb 22, 2023"), and it should on 3.11 within a few hours (it's still "Last updated on Feb 22, 2023").

@SectorCorruptor
Copy link
Contributor Author

Also totally unrelated pointout: for penrose, in 3.11 docs, the description should be

a periodic tiling with kites and darts

not

aperiodic tiling with kites and darts

@hugovk
Copy link
Member

hugovk commented Feb 27, 2023

"aperiodic" is correct here, see Wikipedia:

A Penrose tiling is an example of an aperiodic tiling. Here, a tiling is a covering of the plane by non-overlapping polygons or other shapes, and aperiodic means that shifting any tiling with these shapes by any finite distance, without rotation, cannot produce the same tiling.

JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants