Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-29474: Improve documentation for weakref.WeakValueDictionary #10

Merged
merged 1 commit into from
Feb 12, 2017
Merged

bpo-29474: Improve documentation for weakref.WeakValueDictionary #10

merged 1 commit into from
Feb 12, 2017

Conversation

Mariatta
Copy link
Member

There were some grammatical errors in weakref.WeakValueDictionary
documentation.

This should be applied to 3.5, 3.6, and master.

Original patch was in bpo http://bugs.python.org/file46597/issue29474py3-2.patch

@Mariatta
Copy link
Member Author

Not sure if I'm doing this right.
Is the idea for me to apply the labels backport to 3.5, and backport to 3.6 ?

@zware
Copy link
Member

zware commented Feb 11, 2017

@Mariatta Yes, as far as I know :)

@Mariatta
bpo-29474: Improve documentation for weakref.WeakValueDictionary
c231d45 
There were some grammatical errors in weakref.WeakValueDictionary
documentation.
@codecov
Copy link

codecov bot commented Feb 11, 2017

Codecov Report

Merging #10 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
+ Coverage   82.37%   82.37%   +<.01%     
==========================================
  Files        1427     1427              
  Lines      350948   350948              
==========================================
+ Hits       289088   289091       +3     
+ Misses      61860    61857       -3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7ffb99...c231d45. Read the comment docs.

This was referenced Feb 11, 2017
Merged
Merged
@Mariatta Mariatta merged commit 3110a37 into python:master Feb 12, 2017
@Mariatta Mariatta deleted the bpo-29474 branch February 12, 2017 16:21
ethanhs added a commit to ethanhs/cpython that referenced this pull request Feb 7, 2020
@ethanhs
Remove extraneous whitespace. (python#10)
7b1ad20
@pablogsal pablogsal mentioned this pull request Jun 12, 2020
Closed
@shihai1991 shihai1991 mentioned this pull request Jun 23, 2020
Closed
@larryhastings larryhastings mentioned this pull request Jun 7, 2022
Closed
@itachaaa itachaaa mentioned this pull request Aug 22, 2022
Open
@mdboom mdboom mentioned this pull request Aug 25, 2022
Closed
@mdboom mdboom mentioned this pull request Nov 22, 2022
Closed
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull request Nov 22, 2022
@bors @nanjekyejoannah
Merge python#10
4b248a8 
10: Warn for listcomp r=ltratt a=nanjekyejoannah

Warnings for list comprehension, which include:
- explicit tuple/parentheses for list items
- leaking iterator variable.

Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
@ziegenbalg ziegenbalg mentioned this pull request Nov 30, 2022
Closed
jaraco pushed a commit that referenced this pull request Dec 2, 2022
@Mariatta
Trigger backport on label change (GH-10)
98047ae 
Closes python/miss-islington#9
oraluben referenced this pull request in oraluben/cpython Jun 25, 2023
@Fidget-Spinner @JuliaPoo
fix: backward jump type context compatibility check (#10)
197c0c9 
Co-authored-by: Jules <57632293+JuliaPoo@users.noreply.github.com>
@gvanrossum gvanrossum mentioned this pull request Aug 22, 2023
Closed
@LinanV LinanV mentioned this pull request Oct 23, 2023
Closed
@stasos24 stasos24 mentioned this pull request Oct 24, 2023
Closed
@williamhu020 williamhu020 mentioned this pull request Nov 5, 2023
Closed
@kcatss kcatss mentioned this pull request Nov 15, 2023
Open
@kcatss kcatss mentioned this pull request Jan 14, 2024
Closed
@kcatss kcatss mentioned this pull request Feb 12, 2024
Closed
@kcatss kcatss mentioned this pull request Feb 20, 2024
Closed
@rdoeffinger rdoeffinger mentioned this pull request Jun 27, 2024
Closed
@ngoldbaum ngoldbaum mentioned this pull request Sep 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zware zware zware approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariatta @zware @the-knights-who-say-ni