Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-100348: asyncio._SelectorSocketTransport: free cyclic reference on close() #100349

Merged
merged 3 commits into from
Dec 20, 2022
+6 −0
Merged

gh-100348: asyncio._SelectorSocketTransport: free cyclic reference on close() #100349

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1bf41e
asyncio._SelectorSocketTransport: free cyclic reference on close()
rkojedzinszky Dec 19, 2022
1fcdc13
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 19, 2022
9f62ce0
Update Misc/NEWS.d/next/Library/2022-12-19-19-30-06.gh-issue-100348.o…
kumaraditya303 Dec 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/asyncio/selector_events.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1133,6 +1133,10 @@ def _make_empty_waiter(self):
def _reset_empty_waiter(self):
self._empty_waiter = None

def close(self):
self._read_ready_cb = None
super().close()


class _SelectorDatagramTransport(_SelectorTransport, transports.DatagramTransport):

Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-12-19-19-30-06.gh-issue-100348.o7IAHh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Release _SelectorSocketTransport._read_ready_cb on close() to free up cyclic reference.
kumaraditya303 marked this conversation as resolved.
Show resolved Hide resolved