Skip to content

Update README file extensions to .rst #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 15 commits into from
Closed

Update README file extensions to .rst #105

wants to merge 15 commits into from

Conversation

taycaldwell
Copy link

Updated the file extensions of the README files in the repo to have the .rst file extension so they are rendered properly on GitHub.

@ghost
Copy link

ghost commented Feb 15, 2017

Not all of them should be a simple rename, see if you can bring .rst formatting in the mix.

@refi64
Copy link
Contributor

refi64 commented Feb 15, 2017

If you want, you can also use some of the stuff I did in #5

@taycaldwell
Copy link
Author

taycaldwell commented Feb 15, 2017

@rogersachan Files have now been fixed and updated with proper .rst formatting with respect to how GitHub renders them. A lot of the existing files used proper syntax and looked fine. For those files I just added the file extension so they could be rendered properly.

The biggest formatting changes were applied to the PCBuild README.

@codecov
Copy link

codecov bot commented Feb 15, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@984eef7). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master     #105   +/-   ##
=========================================
  Coverage          ?   82.38%           
=========================================
  Files             ?     1428           
  Lines             ?   351164           
  Branches          ?        0           
=========================================
  Hits              ?   289315           
  Misses            ?    61849           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 984eef7...e3e0d5f. Read the comment docs.

@brettcannon
Copy link
Member

Would it be possible to break this PR up into separate ones per file? I know that might be a pain but it would make it easier to review since e.g. I don't know if @zooba and @zware actually want to the READMEs related to Windows builds to change (plus you stripped out Windows line endings in those files).

@brettcannon
Copy link
Member

GH-104 renames Doc/README.rst as well.

@taycaldwell
Copy link
Author

@brettcannon I'm fine with breaking it down into multiple PRs.

@zooba
Copy link
Member

zooba commented Feb 15, 2017

I'm not concerned about this one (though the other readme "fix" broke our release builds...). Ideally we'd have a .txt version there too so that it's easy to read the file from a clone/tarball, but if the GitHub masses would prefer .rst then I'd rather only have one copy. It's hard enough to keep it up to date already...

@brettcannon
Copy link
Member

OK, then let's do this file-by-file as there's so many PRs flying by that are grabbing this sort of low-hanging fruit it's probably best to do this slowly and methodically so that @taycaldwell doesn't have to constantly rebase because someone did another README.

akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
…e in slp_kill_tasks_with_stacks

Fix the bug and add a test case.

https://bitbucket.org/stackless-dev/stackless/issues/105
(grafted from f7deec75f44dba55bea628b62f89f3c1706bdb68)
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
akruis pushed a commit to akruis/cpython that referenced this pull request Sep 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants