Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105375: Improve PyErr_WarnExplicit() error handling #105610

Merged
merged 7 commits into from
Jun 11, 2023
Merged

gh-105375: Improve PyErr_WarnExplicit() error handling #105610

merged 7 commits into from
Jun 11, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 9, 2023 •
edited by bedevere-bot
Loading

Bail on first error to prevent exceptions from possibly being
overwritten.

@erlend-aasland
pythongh-105375: Improve PyErr_WarnExplicit() error handling
1603759 
Bail on first error to prevent exceptions from possibly being
overwritten.
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jun 9, 2023
@erlend-aasland erlend-aasland requested a review from sobolevn June 9, 2023 21:36
@bedevere-bot bedevere-bot mentioned this pull request Jun 9, 2023
Closed
18 tasks
sobolevn
sobolevn reviewed Jun 10, 2023
View reviewed changes
Python/_warnings.c Outdated Show resolved Hide resolved
@erlend-aasland erlend-aasland added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 11, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit b7f3245 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@erlend-aasland erlend-aasland requested a review from sobolevn June 11, 2023 10:27
@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Jun 11, 2023
sobolevn
sobolevn approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@erlend-aasland
Copy link
Contributor Author

Great, thank you!

Thanks for all the reviews! Very helpful.

@erlend-aasland
Copy link
Contributor Author

Ref. leak runs are still unusable bco. the test_import and test_peg_generator failures :(

@erlend-aasland erlend-aasland merged commit 567d6ae into python:main Jun 11, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@erlend-aasland erlend-aasland deleted the improve-warnings-error-handling branch June 11, 2023 19:23
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve PyErr_WarnExplicit() error handling (pythonG…
0b80806 
…H-105610)

Bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 567d6ae)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105659 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jun 11, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@erlend-aasland @miss-islington
pythongh-105375: Improve PyErr_WarnExplicit() error handling (pythonG…
dc4aa1d 
…H-105610)

Bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 567d6ae)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105660 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
@erlend-aasland erlend-aasland linked an issue Jun 11, 2023 that may be closed by this pull request
Incorrect error handling for APIs that can raise exceptions #105375
Closed
18 tasks
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.11] gh-105375: Improve PyErr_WarnExplicit() error handling (GH-105610
05c73e1 
) (#105660)

Bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 567d6ae)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
@miss-islington @erlend-aasland
[3.12] gh-105375: Improve PyErr_WarnExplicit() error handling (GH-105610
db5022c 
) (#105659)

Bail on first error to prevent exceptions from possibly being
overwritten.
(cherry picked from commit 567d6ae)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect error handling for APIs that can raise exceptions
4 participants
@erlend-aasland @bedevere-bot @miss-islington @sobolevn