Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-105375: Improve PyErr_WarnExplicit() error handling #105610

Merged
merged 7 commits into from
Jun 11, 2023
Merged

gh-105375: Improve PyErr_WarnExplicit() error handling #105610

merged 7 commits into from
Jun 11, 2023

Commits on Jun 9, 2023

  1. pythongh-105375: Improve PyErr_WarnExplicit() error handling 

    Bail on first error to prevent exceptions from possibly being
overwritten.
    @erlend-aasland
    erlend-aasland committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    1603759 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2023

  1. Fix maybe-uinitialized warning

    @erlend-aasland
    erlend-aasland committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    7fe31c2 View commit details
    Browse the repository at this point in the history

  2. Pull in main

    @erlend-aasland
    erlend-aasland committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    f07fce8 View commit details
    Browse the repository at this point in the history

  3. 'module' can also be uninitialized

    @erlend-aasland
    erlend-aasland committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    91c7c6c View commit details
    Browse the repository at this point in the history

  4. Don't 'goto exit' for the first error check

    @erlend-aasland
    erlend-aasland committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    d05d740 View commit details
    Browse the repository at this point in the history

  5. Rewrite it

    @erlend-aasland
    erlend-aasland committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    5c5100a View commit details
    Browse the repository at this point in the history

  6. Also decref 'message' and 'filename'

    @erlend-aasland
    erlend-aasland committed Jun 10, 2023
    Configuration menu
    Copy the full SHA
    b7f3245 View commit details
    Browse the repository at this point in the history