Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104683: clinic.py: refactor four simple classes as dataclasses #106476

Merged
merged 1 commit into from
Jul 6, 2023
Merged

gh-104683: clinic.py: refactor four simple classes as dataclasses #106476

merged 1 commit into from
Jul 6, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jul 6, 2023 •
edited by bedevere-bot
Loading

This cuts a fair amount of boilerplate and repetition in __init__ methods

@bedevere-bot bedevere-bot mentioned this pull request Jul 5, 2023
Closed
7 tasks
@AlexWaygood AlexWaygood mentioned this pull request Jul 6, 2023
Merged
erlend-aasland
erlend-aasland approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AlexWaygood AlexWaygood merged commit 5548097 into python:main Jul 6, 2023
19 checks passed
@AlexWaygood AlexWaygood deleted the clinic-dataclasses-2 branch July 26, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @erlend-aasland @bedevere-bot