Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-104683: clinic.py: refactor Parameter and Function as dataclasses #106477

Merged
merged 3 commits into from
Jul 7, 2023
Merged

gh-104683: clinic.py: refactor Parameter and Function as dataclasses #106477

merged 3 commits into from
Jul 7, 2023

Conversation

AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Jul 6, 2023 •
edited by bedevere-bot
Loading

Split off from #106476 as these are slightly more complex refactors (but worth doing, imo)

@bedevere-bot bedevere-bot mentioned this pull request Jul 6, 2023
Closed
7 tasks
erlend-aasland
erlend-aasland approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; these are very nice improvements.

AlexWaygood
AlexWaygood commented Jul 7, 2023
View reviewed changes
Tools/clinic/clinic.py Outdated Show resolved Hide resolved
@AlexWaygood AlexWaygood enabled auto-merge (squash) July 7, 2023 12:44
@AlexWaygood AlexWaygood merged commit 363f4f9 into python:main Jul 7, 2023
15 checks passed
@AlexWaygood AlexWaygood deleted the clinic-function-dataclass branch July 7, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexWaygood @erlend-aasland @bedevere-bot