-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-108223: Refer to PEP 703 as Free Threading #112780
Conversation
Should the See the steering council decision: python/steering-council#221 (comment) |
cc @hugovk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We already changed the term from Py_NOGIL to Py_GIL_DISABLED.
Do we have to touch this term all things one more time?
See PRs of #111863
Ah okay, python/steering-council#221 (comment) was announced 2 hours ago. |
Naming is hard :-) The update is that the Steering Council took a decision. But this PR is not about Py_GIL_DISABLED macro which can be renamed in a following PR if needed. |
I'm confused. Didn't the SC decision explicitly mention that Py_GIL_DISABLED is ok? |
I have the same opinion as @itamaro |
No, we keep The SC said yesterday:
python/steering-council#221 (comment) This PR doesn't touch the macro though. It changes a constant used by unit tests. This isn't exposed to users, so we could keep it as is, but are also free to change it. However, because the constant is directly looking up the macro value from |
Lib/test/libregrtest/utils.py
Outdated
@@ -291,7 +291,7 @@ def get_build_info(): | |||
|
|||
# --disable-gil | |||
if sysconfig.get_config_var('Py_GIL_DISABLED'): | |||
build.append("nogil") | |||
build.append("freethreading") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
build.append("freethreading") | |
build.append("gil_disabled") |
I updated the PR. Please review it again.
Oh ok. I read the announcement too quickly, I missed the part about Py_GIL_DISABLED.
Ok, I updated my PR for that. @hugovk proposed |
Merged, thanks for reviews. |
Rename support.Py_GIL_DISABLED to support.FREE_THREADING.
📚 Documentation preview 📚: https://cpython-previews--112780.org.readthedocs.build/