[3.12] gh-114014: Update fractions.Fraction()'s rational parsing regex (GH-114015)
#114023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ex (pythonGH-114015) Fix a bug in the regex used for parsing a string input to the `fractions.Fraction` constructor. That bug led to an inconsistent exception message being given for some inputs. --------- (cherry picked from commit dd56b57) Co-authored-by: Crowthebird <78076854+thatbirdguythatuknownot@users.noreply.github.com> Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com> Co-authored-by: Mark Dickinson <dickinsm@gmail.com>
This was referenced Jan 13, 2024
|
Looks like we need #114022 to be merged first to resolve the doc build issues. |
|
The doc fix was merged, CI green, so I merged this and 3.11. |
|
Thanks, @terryjreedy! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the regex used for parsing a string input to the
fractions.Fractionconstructor. That bug led to an inconsistent exception message being given for some inputs.(cherry picked from commit dd56b57)
Co-authored-by: Crowthebird 78076854+thatbirdguythatuknownot@users.noreply.github.com
Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Mark Dickinson dickinsm@gmail.com
fractions.Fraction()initialization error with invalid string #114014