-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-112844: Add SBOM for external dependencies #115789
Conversation
Probably, though in practice we don't patch anything. The only patch I'm aware of right now is to make OpenSSL look in our
Not really. We do a copy from source releases into our repo, so there's no tracking history back upstream, and while we should import and patch in separate commits, that doesn't really do it robustly. But we're not carrying any patches here right now, so it's a moot point. And I think you got all the ones that live in the main repo already (if any)? |
LGTM |
@sethmlarson Ready to merge this? |
@hugovk Ready to merge! |
Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
(cherry picked from commit 45d8871) Co-authored-by: Seth Michael Larson <seth@python.org>
GH-116128 is a backport of this pull request to the 3.12 branch. |
This PR adds an SBOM and tooling for dependencies specified in
get_externals.bat
for Windows builds. This SBOM will be picked up byrelease-tools
to generated SBOMs for Windows artifacts.One question I had was whether we should handle our "patched" versions of dependencies, and if so if there was any known way for this tool to detect that (short of tracking it ourselves).