Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-112844: Add SBOM for external dependencies #115789

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

sethmlarson
Copy link
Contributor

@sethmlarson sethmlarson commented Feb 21, 2024

This PR adds an SBOM and tooling for dependencies specified in get_externals.bat for Windows builds. This SBOM will be picked up by release-tools to generated SBOMs for Windows artifacts.

One question I had was whether we should handle our "patched" versions of dependencies, and if so if there was any known way for this tool to detect that (short of tracking it ourselves).

@zooba
Copy link
Member

zooba commented Feb 21, 2024

One question I had was whether we should handle our "patched" versions of dependencies

Probably, though in practice we don't patch anything. The only patch I'm aware of right now is to make OpenSSL look in our _ssl module for its embedded table rather than in python.exe, which should have no security impact. That patch happens automatically at build time.

and if so if there was any known way for this tool to detect that (short of tracking it ourselves).

Not really. We do a copy from source releases into our repo, so there's no tracking history back upstream, and while we should import and patch in separate commits, that doesn't really do it robustly.

But we're not carrying any patches here right now, so it's a moot point. And I think you got all the ones that live in the main repo already (if any)?

Tools/build/generate_sbom.py Outdated Show resolved Hide resolved
@zooba
Copy link
Member

zooba commented Feb 28, 2024

LGTM

@hugovk
Copy link
Member

hugovk commented Feb 29, 2024

@sethmlarson Ready to merge this?

@sethmlarson
Copy link
Contributor Author

@hugovk Ready to merge!

@hugovk hugovk merged commit 45d8871 into python:main Feb 29, 2024
38 checks passed
@miss-islington-app
Copy link

Thanks @sethmlarson for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 29, 2024
(cherry picked from commit 45d8871)

Co-authored-by: Seth Michael Larson <seth@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Feb 29, 2024

GH-116128 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Feb 29, 2024
@sethmlarson sethmlarson deleted the sbom-externals branch February 29, 2024 15:52
hugovk pushed a commit that referenced this pull request Feb 29, 2024
…6128)

Co-authored-by: Seth Michael Larson <seth@python.org>
woodruffw pushed a commit to woodruffw-forks/cpython that referenced this pull request Mar 4, 2024
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants