-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SBOMs generation for Windows artifacts #100
Conversation
41541f8
to
26eacab
Compare
70ae846
to
1d23d2d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm confident enough we need the &
in there that I'll wait for that change before running another build.
You're using gci
fine, btw (it's short for Get-ChildItem
which is also aliased as dir
and ls
, because who needs only one way to do things...)
New test build running at https://dev.azure.com/Python/cpython/_build/results?buildId=152746&view=results |
@zooba Thanks for the run, the joys of developing CI workflow definitions continues :) |
Looking at the most recent failure, it seems you probably want |
a47707a
to
8cb1ff1
Compare
The SBOM artifacts are getting uploaded into the I downloaded them all and gave them a look, they contain the components I expect and SBOM tooling accepts them. This PR can be ready to go as-is or we could also add the "upload" step in this PR too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just be able to add a *.spdx.json
wildcard to $exe
in uploadrelease.ps1
to pick up the SBOMs, right? Or maybe add a new parameter like $embed
to specify the directory, to save copying them into the main directory.
TBH, I don't love the whole upload script, I just haven't looked at it in years (and it was written for a local build, which doesn't look like the automated one). Take a look and see whether you have a desperate desire to rewrite it, in which case we can do a new PR, or if you can easily hack it in then we can do it now.
Moved the branch to this repo to allow testing before merging in Azure Pipelines. Requires python/cpython#115789 to be checked in to work.