gh-117722: Fix Stream.readuntil with non-bytes buffer objects #117723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR python#16429 introduced support for an iterable of separators in Stream.readuntil. Since bytes-like types are themselves iterable, this can introduce ambiguities in deciding whether the argument is an iterator of separators or a singleton separator. In python#16429, only 'bytes' was considered a singleton, but this will break code that passes other buffer object types. Fix it by only supporting tuples rather than arbitrary iterables. Closes python#117722.
bmerry
requested review from
1st1,
asvetlov,
gvanrossum,
kumaraditya303 and
willingc
as code owners
gvanrossum
approved these changes
Apr 11, 2024
There was a problem hiding this comment.
This looks good. Since your previous change made it into 3.13a6 it will be somewhat interesting to see if anybody actually notices a problem with that -- which would be an indicator of how much this matters (I expect very little :-). (If it hadn't made it in, I'd have recommended merging the changelog snippets, but it's too late for that now.)
I noticed that there isn't yet a bullet for this in Doc/whatsnew/3.13.rst -- do you feel like adding one? If you do, you could add it to this PR; I'll keep it open for a day or until I hear from you.
Sure - done. |
gvanrossum
approved these changes
Apr 11, 2024
|
Thanks! You're welcome to contribute more any time, it's been a pleasure to work with you. (And again, apologies for the delay. :-) |
|
Make a python language power my uncle which will help me to solve some
complex problems in the field of science in future through future quantum
computer make this programming language as easy as possible many thanks.
…On Thu, Apr 11, 2024, 7:45 PM Guido van Rossum ***@***.***> wrote:
Thanks! You're welcome to contribute more any time, it's been a pleasure
to work with you. (And again, apologies for the delay. :-)
—
Reply to this email directly, view it on GitHub
<#117723 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/BHTFZRB7VENGHUQMLYOZREDY42OYHAVCNFSM6AAAAABGA7G2J6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBZHA2TQMBSGM>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
…ython#117723) pythongh-16429 introduced support for an iterable of separators in Stream.readuntil. Since bytes-like types are themselves iterable, this can introduce ambiguities in deciding whether the argument is an iterator of separators or a singleton separator. In pythongh-16429, only 'bytes' was considered a singleton, but this will break code that passes other buffer object types. Fix it by only supporting tuples rather than arbitrary iterables. Closes pythongh-117722.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #16429 introduced support for an iterable of separators in Stream.readuntil. Since bytes-like types are themselves iterable, this can introduce ambiguities in deciding whether the argument is an iterator of separators or a singleton separator. In #16429, only 'bytes' was considered a singleton, but this will break code that passes other buffer object types.
Fix it by only supporting tuples rather than arbitrary iterables.
Closes #117722.
📚 Documentation preview 📚: https://cpython-previews--117723.org.readthedocs.build/