Update asyncio.Stream.readuntil #11755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bmerry
commented
Apr 14, 2024
bmerry
commented
- Make use of ReadableBuffer to generalise the arguments accepted (implementing the suggestion made in a comment).
- Support a tuple of separators in Python 3.13, as implemented in gh-81322: support multiple separators in Stream.readuntil cpython#16429 and gh-117722: Fix Stream.readuntil with non-bytes buffer objects cpython#117723.
- Make use of ReadableBuffer to generalise the arguments accepted (implementing the suggestion made in a comment). - Support a tuple of separators in Python 3.13, as implemented in python/cpython#16429 and python/cpython#117723.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Apr 14, 2024
Collaborator
srittau
left a comment
srittau
left a comment
There was a problem hiding this comment.
Thanks, and congratulations on getting that PR merged after only short five years. :) On issue below.
stdlib/asyncio/streams.pyi
Outdated
| # Can be any buffer that supports len(); consider changing to a Protocol if PEP 688 is accepted | ||
| async def readuntil(self, separator: bytes | bytearray | memoryview = b"\n") -> bytes: ... | ||
| if sys.version_info >= (3, 13): | ||
| async def readuntil(self, separator: _ReaduntilBuffer | tuple[_ReaduntilBuffer] = b"\n") -> bytes: ... |
Collaborator
There was a problem hiding this comment.
Suggested change
| async def readuntil(self, separator: _ReaduntilBuffer | tuple[_ReaduntilBuffer] = b"\n") -> bytes: ... | |
| async def readuntil(self, separator: _ReaduntilBuffer | tuple[_ReaduntilBuffer, ...] = b"\n") -> bytes: ... |
Contributor
Author
There was a problem hiding this comment.
Thanks, I'm always making that mistake with tuples. Fixed now.
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Apr 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.