-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
gh-122085: Use include files for whatsnew/3.13.rst
deprecations
#121241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
What happens if an entry from "Pending Removal in Future Versions" moves to "Pending Removal in Python 3.16"? |
Then we move it from |
Yes, but then it wouldn't show up in the list of future deprecations for 3.13 if 3.16 isn't included (which would be easy to forget when added). |
Correct, when creating a new include file, you need to remember to add it to the relevant pages. |
This only covers the C API, not the Python API. Is that intended? |
TODO: This was meant to be for the Python deprecations, not C API ones. I'll update it. |
What will we do with the C API? Do we include it like this? Or do we put it in a separate file? .. include:: ../deprecations/pending-removal-in-3.14.rst
:start-after: .. start_pending_removal_in_3_14_capi
:end-before: .. end_pending_removal_in_3_14_capi |
No, I think it would be easier to have each in their own files (not necessarily named like this):
|
8a461c5
to
2e85df9
Compare
Updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, with one typo fix!
@@ -1631,318 +1631,13 @@ New Deprecations | |||
|
|||
.. Add deprecations above alphabetically, not here at the end. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it make sense to add a new "Pending removal" section, with a paragraph describing what "pending removal" means, and include the other files as subsections?
These are currently nested under "New Deprecation" (not sure if intentionally):
I also noticed that there are two "Pending Removal in Python 3.x", for each "x", e.g.:
- https://cpython-previews--121241.org.readthedocs.build/en/121241/whatsnew/3.13.html#pending-removal-in-python-3-14
- https://cpython-previews--121241.org.readthedocs.build/en/121241/whatsnew/3.13.html#id7
Is this intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest not expanding the scope of the PR. Move the content in this one, rearrange the page later (and possibly only for 3.14).
I also noticed that there are two "Pending Removal in Python 3.x", for each "x", e.g.:
Yes, there are separate sections for Python API and C API, and they're not presented very clearly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I followed up on this in the original issue:
Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry, @hugovk, I could not cleanly backport this to
|
(cherry picked from commit a1df1b4) Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
GH-122038 is a backport of this pull request to the 3.13 branch. |
whatsnew/3.13.rst
deprecations
GH-122038 is a backport of this pull request to the 3.13 branch. |
1 similar comment
GH-122038 is a backport of this pull request to the 3.13 branch. |
Re: https://discuss.python.org/t/streamline-whats-new-by-moving-deprecations-and-removals-out-of-news/53997/8
This moves these sections out of "What's New in Python 3.13" into include files:
Later PRs will add includes to other What's New files, to avoid needing to duplicate and sync these sections between files. And we can later also create a dedicated page to list deprecations.
📚 Documentation preview 📚: https://cpython-previews--121241.org.readthedocs.build/