Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-122085: Use include files for C API deprecations #109843

Merged
merged 10 commits into from
Jul 29, 2024

Conversation

AA-Turner
Copy link
Member

@AA-Turner AA-Turner commented Sep 25, 2023

Doc/whatsnew/3.13.rst Outdated Show resolved Hide resolved
@vstinner
Copy link
Member

If you move these sub-sections of the C API section, you should also move the other ones of the "main" Python section: moving "Pending Removal in Python 3.14" after Removal. What do you think?

Screenshot 2023-09-26 at 10-18-55 What’s New In Python 3 13

@AA-Turner
Copy link
Member Author

Personally, I probably wouldn't as I think semantically it makes more sense to note the pending removals for Python APIs within the Deprecated section -- they are a concise list of how quickly readers will need to adapt to the new APIs.

A

@vstinner
Copy link
Member

they are a concise list

My concern is more that these lists are getting bigger at every Python version. Sometimes, I'm considering to create a sub-page of What's New in Python 3.13, since the document is so big, that people may give up to just start reading it. Deprecation/Removal only interest a minority of people.

The whole What's New in Python 3.13 takes 18 pages if I print it as PDF with my default browser configuration.


I don't have a strong opinon between:

  • Deprecations

    • Pending Removals ...
  • Removal

VERSUS:

  • Deprecations
  • Removal
  • Pending Removals ...

I would just prefer to have consistency between the (main) Python section and the C API Changes section.


If you prefer to have "Pending Removals ..." under the Deprecations section, please just make it consistent in the doc.

@AA-Turner AA-Turner closed this Sep 29, 2023
@AA-Turner AA-Turner deleted the docs/whatsnew/c-api-3.13 branch September 29, 2023 08:16
@AA-Turner AA-Turner restored the docs/whatsnew/c-api-3.13 branch September 29, 2023 08:52
@AA-Turner AA-Turner reopened this Sep 29, 2023
Copy link
Contributor

@blaisep blaisep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text is cleaner than before, thank you.
I can't confirm that the content is correct, I hope this gets merged soon.

@hugovk
Copy link
Member

hugovk commented May 21, 2024

My concern is more that these lists are getting bigger at every Python version. Sometimes, I'm considering to create a sub-page of What's New in Python 3.13, since the document is so big, that people may give up to just start reading it. Deprecation/Removal only interest a minority of people.

I agree with this.

I want us to have a static page of pending deprecations, so we don't need to worry synchronising across both pages (3.14.rst <-> 3.13.rst <-> 3.12.rst etc.) and branches (main <-> 3.13 <-> 3.12).

And we sometimes do forget to update them, for example #118947. Additionally, at some point a branch goes to security-fix only, and we can no longer update the What's New.

Then, in "What's New in Python 3.x", we should only list the deprecations newly added in that release.


Compare the pytest page:

As a user of pytest, this is a useful one-stop page to look where I need to update my code.

I copied it for Pillow:

As a maintainer of Pillow, this is a useful one-stop page to look for old deprecations to remove in the next release.

@blaisep
Copy link
Contributor

blaisep commented May 21, 2024

(OK, I can see that there is more to this than I originally thought)

It seems like the current consensus is to have something like

Doc/whatsnew/deprecations/removal.rst
Doc/whatsnew/deprecations/removalpending.rst
Doc/whatsnew/deprecations/deprecations.rst

and possibly some Doc/whatsnew/deprecations/index.rst with a bit of .. toctree:: sugar sprinkles?
Shall I bring this up in the docs discord?

@hugovk
Copy link
Member

hugovk commented Jul 1, 2024

@AA-Turner AA-Turner changed the title What's New in Python 3.13: Synchronise C API 'Pending Removal' with 3.12 GH-122085: Use include files for C API deprecations Jul 27, 2024
@AA-Turner AA-Turner added needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Jul 27, 2024
@AA-Turner
Copy link
Member Author

With apologies for the force-push, I have hijacked my own PR to use the include-file approach for the C API, whilst still doing the synchronisation.

I've split the work into individual commits, which should be somewhat easy to follow.

A

@hugovk hugovk changed the title GH-122085: Use include files for C API deprecations gh-122085: Use include files for C API deprecations Jul 27, 2024
@hugovk
Copy link
Member

hugovk commented Jul 27, 2024

Is it so that we weren't previously duplicating all the C API deprecations across What's New files?

This will mean the What's New pages will become even longer. But I suppose if we do it for the Python deprecations, that's an argument for also doing it for the C API ones too.

@AA-Turner
Copy link
Member Author

AA-Turner commented Jul 27, 2024

Is it so that we weren't previously duplicating all the C API deprecations across What's New files?

Almost all of the deprecations were in both 3.12 and 3.13, it was only 3.14 that was sparse, so I think it is worth both ensuring there's consistency and that we advertise the deprecations in all What's New pages.

A

@hugovk
Copy link
Member

hugovk commented Jul 28, 2024

Would you like to add these includes to the new deprecations/index.rst from #122352?


I also realised we don't want .. include:: pending-removal-in-3.14.rst here in main (aka 3.14), we only want to list later versions:

.. include:: pending-removal-in-3.14.rst

The backports are correct:

Please could you also remove that line at the same time?

@AA-Turner
Copy link
Member Author

Would you like to add these includes to the new deprecations/index.rst

Done

Please could you also remove that line at the same time?

Done

A

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AA-Turner AA-Turner merged commit 76bdfa4 into python:main Jul 29, 2024
24 of 25 checks passed
@AA-Turner AA-Turner deleted the docs/whatsnew/c-api-3.13 branch July 29, 2024 21:20
@miss-islington-app
Copy link

Thanks @AA-Turner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 76bdfa4cd02532519fb43ae91244e2b4b3650d78 3.13

@miss-islington-app
Copy link

Sorry, @AA-Turner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 76bdfa4cd02532519fb43ae91244e2b4b3650d78 3.12

AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Jul 29, 2024
…honGH-109843)

(cherry picked from commit 76bdfa4)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 29, 2024

GH-122422 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 29, 2024
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Jul 29, 2024
…honGH-109843)

(cherry picked from commit 76bdfa4)

Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 29, 2024

GH-122423 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Jul 29, 2024
AA-Turner added a commit that referenced this pull request Jul 29, 2024
AA-Turner added a commit that referenced this pull request Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants