GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section #109751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AA-Turner
requested review from
ambv,
vstinner,
hugovk and
serhiy-storchaka
bedevere-app
bot
added
awaiting review
docs
AA-Turner
commented
Sep 22, 2023
Comment on lines
-1258
to
-1259
| * Creating :c:data:`immutable types <Py_TPFLAGS_IMMUTABLETYPE>` with mutable | ||
| bases using the C API (:gh:`95388`) |
There was a problem hiding this comment.
Note this entry was duplicated; I've only kept one of them
AA-Turner
changed the title
vstinner
approved these changes
Sep 24, 2023
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka
approved these changes
Sep 25, 2023
| * :c:func:`!PyUnicode_AsEncodedUnicode`: use c:func:`PyCodec_Encode` | ||
| * :c:func:`PyUnicode_READY`: unneeded since Python 3.12 | ||
| * :c:func:`!PyErr_Display`: use :c:func:`PyErr_DisplayException` | ||
| * :c:func:`!_PyErr_ChainExceptions`: use ``_PyErr_ChainExceptions1`` |
There was a problem hiding this comment.
I am not sure about this. It is an internal convenient function, and it can be removed or changed in incompatible way without warning.
There was a problem hiding this comment.
We're recommending a private replacement to a private function here, so I think it's fine. This isn't saying that readers should use the functions, just what the replacements for the deprecated versions are.
hugovk
reviewed
Sep 25, 2023
hugovk
approved these changes
Sep 25, 2023
|
Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Sep 25, 2023
…ions section (pythonGH-109751) (cherry picked from commit bccc1b7) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-109830 is a backport of this pull request to the 3.12 branch. |
|
Would you mind to copy the "Pending Removal xxx" sections of C API Changes to What's New In Python 3.13? (main branch) |
|
Done: #109843 A |
Yhg1s
pushed a commit
that referenced
this pull request
Sep 26, 2023
…tions section (GH-109751) (#109830) * GH-109190: Copyedit 3.12 What's New: Improve the C-API deprecations section (GH-109751) (cherry picked from commit bccc1b7) Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com> * Remove the weakref get object functions --------- Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com> Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
csm10495
pushed a commit
to csm10495/cpython
that referenced
this pull request
Sep 28, 2023
…ions section (python#109751) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
…ions section (python#109751) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ma_version_tagand immutable types / mutable bases to the C-API section📚 Documentation preview 📚: https://cpython-previews--109751.org.readthedocs.build/