gh-119180: Add evaluate functions for type params and type aliases #122212
+385
−159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
requested review from
ericsnowcurrently,
carljm,
markshannon and
iritkatriel
as code owners
29 tasks
JelleZijlstra
force-pushed
the
pep649-typevar2
branch
from
902af47 to
39b4a57
Compare
carljm
approved these changes
Jul 26, 2024
Objects/genericaliasobject.c
Outdated
|
|
||
| static int | ||
| ga_repr_items_list(PyUnicodeWriter *writer, PyObject *p) | ||
| ga_repr_items_list(_PyUnicodeWriter *writer, PyObject *p) |
There was a problem hiding this comment.
It looks like this change from PyUnicodeWriter * to _PyUnicodeWriter * in this signature causes a lot of compiler warnings below.
There was a problem hiding this comment.
Thanks, there was a change to this API since I first wrote the code and I may not have merged properly.
JelleZijlstra
added
the
🔨 test-with-refleak-buildbots
|
🤖 New build scheduled with the buildbot fleet by @JelleZijlstra for commit 742400f 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
|
Going to merge this if the refleak buildbots are happy |
|
I submitted #122362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the following section of PEP 749: https://peps.python.org/pep-0749/#deferred-evaluation-of-pep-695-and-696-objects