Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-122361: Use proper PyUnicodeWriter_* API in constevaluator_call #122362

Merged
merged 2 commits into from
Jul 27, 2024
Merged

gh-122361: Use proper PyUnicodeWriter_* API in constevaluator_call #122362

merged 2 commits into from
Jul 27, 2024

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 27, 2024 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested a review from JelleZijlstra July 27, 2024 17:47
@sobolevn sobolevn requested a review from markshannon as a code owner July 27, 2024 17:47
@bedevere-app bedevere-app bot mentioned this pull request Jul 27, 2024
Closed
@sobolevn sobolevn mentioned this pull request Jul 27, 2024
Merged
picnixz
picnixz reviewed Jul 27, 2024
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?

Objects/typevarobject.c Outdated Show resolved Hide resolved
Objects/typevarobject.c Outdated Show resolved Hide resolved
JelleZijlstra
JelleZijlstra approved these changes Jul 27, 2024
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, thought I got all the warnings.

@sobolevn sobolevn merged commit 04eb5c8 into python:main Jul 27, 2024
37 checks passed
@sobolevn
Copy link
Member Author

How much is the overhead of using the public API instead of the (slightly, or perhaps more) faster private API?

Oups, sorry, @picnixz, I missed this question!
I don't really think that it really matters in this use-case :)

@picnixz
Copy link
Member

picnixz commented Jul 27, 2024

No worry (I also don't think it matters (I didn't know in which context it was being used actually))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnixz picnixz picnixz left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @picnixz @JelleZijlstra