[3.13] gh-126417: validate ABC methods on multiprocessing proxy types (GH-126454) #126674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ythonGH-126454) Checks that appropriate dunder __ methods exist on the dict and list proxy types. (cherry picked from commit 6ee542d) Co-authored-by: Stephen Morton <git@tungol.org> Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
|
The backport of the original PR has proven to be somewhat controversial (#126451 (comment)) and I think the failing tests here validate the concerns others have raised. I think it's probably better to revert the backport of the original PR rather than fix the tests here. I'll take that on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks that appropriate dunder __ methods exist on the dict and list proxy types.
(cherry picked from commit 6ee542d)
Co-authored-by: Stephen Morton git@tungol.org
Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com