-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.13] gh-126413: Add translation tests for getopt and optparse (GH-126698) #126755
Conversation
…pythonGH-126698) (cherry picked from commit dff074d) Co-authored-by: Tomas R. <tomas.roun8@gmail.com>
I'm looking into the test failures |
Looks like pygettext is getting tripped up by this: Line 41 in 865f096
This was removed by another PR of mine which was not backported: #126358 (which is why this did not fail on main) @serhiy-storchaka What do you think? |
I think that changing pygettext is more preferable. This will benefit not only us, but all users. But if it is non-trivial, backporting #126358 is the second good option. |
I agree that fixing this in pygettext is better, I'm gonna see if I can come up with a simple fix |
I think I found a pretty simple fix, I'll send a PR tomorrow :) |
CI's looking good now both here and on the 3.12 backport #126756 🙂 @serhiy-storchaka |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
(cherry picked from commit dff074d)