Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-126789: Correct sysconfig test exclusions for iOS and Android. #126941

Merged
merged 3 commits into from
Nov 18, 2024
Merged

gh-126789: Correct sysconfig test exclusions for iOS and Android. #126941

merged 3 commits into from
Nov 18, 2024
+5 −4

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Nov 18, 2024 •
edited
Loading

#126812 (backported to 3.13 as #126918) added some new tests for the sysconfig module. These tests were skipped on WASI platforms - but the underlying problem exists on all platforms that don't provide subprocess.

This PR modifies the test skip to check for subprocess availability.

There's an argument to be made that this should also be backported to 3.12, as the original PR was backported (see #126919); but the fix isn't required there because iOS and Android aren't supported on 3.12.

@freakboy3742 freakboy3742 added tests Tests in the Lib/test dir skip news OS-ios OS-android needs backport to 3.13 bugs and security fixes labels Nov 18, 2024
@bedevere-app bedevere-app bot mentioned this pull request Nov 18, 2024
Closed
@freakboy3742
Copy link
Contributor Author

!buildbot iOS
!buildbot Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit ca104cc 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit ca104cc 🤖

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@freakboy3742 freakboy3742 mentioned this pull request Nov 18, 2024
Merged
@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit d77c708 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

!buildbot android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit d77c708 🤖

The command will test the builders whose names match following regular expression: android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@freakboy3742
Copy link
Contributor Author

Not sure what's going on with Bevedere, but he seems to have triggered a lot more builds than were requested...

@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit a70f3e9 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

!buildbot Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit a70f3e9 🤖

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@freakboy3742 freakboy3742 added the needs backport to 3.12 bug and security fixes label Nov 18, 2024
@encukou encukou merged commit 3938fd6 into python:main Nov 18, 2024
39 checks passed
@miss-islington-app
Copy link

Thanks @freakboy3742 for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @freakboy3742 and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3938fd60c0c88891b213097380aeea91a45bcd77 3.13

@miss-islington-app
Copy link

Sorry, @freakboy3742 and @encukou, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 3938fd60c0c88891b213097380aeea91a45bcd77 3.12

@bedevere-app
Copy link

bedevere-app bot commented Nov 18, 2024

GH-126950 is a backport of this pull request to the 3.13 branch.

encukou pushed a commit to encukou/cpython that referenced this pull request Nov 18, 2024
@freakboy3742 @encukou
pythongh-126789: Correct sysconfig test exclusions for iOS and Androi…
02198cd 
…d. (pythonGH-126941)

(cherry picked from commit 3938fd6)
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Nov 18, 2024
@freakboy3742 freakboy3742 deleted the sysconfig-tests branch November 18, 2024 10:45
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Nov 18, 2024
@freakboy3742
[3.13] pythongh-126789: Correct sysconfig test exclusions for iOS and…
0eecbd2 
… Android. (pythonGH-126941)

(cherry picked from commit 3938fd6)
freakboy3742 added a commit to freakboy3742/cpython that referenced this pull request Nov 18, 2024
@freakboy3742
[3.12] pythongh-126789: Correct sysconfig test exclusions for iOS and…
5472661 
… Android. (pythonGH-126941)

(cherry picked from commit 3938fd6)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@bedevere-app
Copy link

bedevere-app bot commented Nov 18, 2024

GH-126959 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Nov 18, 2024
encukou added a commit that referenced this pull request Nov 18, 2024
@encukou @freakboy3742
[3.13] gh-126789: Correct sysconfig test exclusions for iOS and Andro…
da7e93d 
…id. (GH-126941) (GH-126950)

(cherry picked from commit 3938fd6)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
encukou pushed a commit that referenced this pull request Nov 19, 2024
@freakboy3742
[3.12] gh-126789: Correct sysconfig test exclusions for iOS and Andro…
1f911ba 
…id. (GH-126941) (GH-126959)

(cherry picked from commit 3938fd6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees

@encukou encukou

Labels
OS-android OS-ios skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@freakboy3742 @bedevere-bot @encukou