Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.12] gh-126789: Correct sysconfig test exclusions for iOS and Android. (GH-126941) #126959

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

freakboy3742
Copy link
Contributor

@freakboy3742 freakboy3742 commented Nov 18, 2024

… Android. (pythonGH-126941)

(cherry picked from commit 3938fd6)

Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
@freakboy3742
Copy link
Contributor Author

!buildbot iOS

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 5472661 🤖

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR

@freakboy3742
Copy link
Contributor Author

!buildbot Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 5472661 🤖

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • aarch64 Android PR
  • AMD64 Android PR

@freakboy3742
Copy link
Contributor Author

@encukou Triggering the iOS and Android buildbots was a mental glitch on my part - of course they won't pass on a 3.12 buildbot... 3.12 didn't support iOS or Android 🤦

So - my read is that this is good to merge, because it's passing all the stable buildbots; but I'd prefer another set of eyeballs on the patch (even though it's the same patch as 3.13), plus a verification of my "this needs a backport" assertion.

@encukou
Copy link
Member

encukou commented Nov 19, 2024

another set of eyeballs on the patch

👀 +1 :)

verification of my "this needs a backport" assertion.

IMO, it doesn't need a backport.
I don't think it'll help users -- people who support other platforms probably have their own patches/skips already, and someone bootstrapping support for a new platform is better off with 3.13.
But, we do generally backport test fixes. It makes future backports easier.

@encukou encukou merged commit 1f911ba into python:3.12 Nov 19, 2024
135 of 151 checks passed
@freakboy3742 freakboy3742 deleted the backport-3938fd6-3.12 branch November 19, 2024 23:41
@freakboy3742
Copy link
Contributor Author

IMO, it doesn't need a backport.... But, we do generally backport test fixes. It makes future backports easier.

Yeah - that was my reasoning as well. Thanks for confirming I was on the right track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants