Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asyncio test case #13228

Closed
wants to merge 11 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Lib/test/test_support.py
Original file line number Diff line number Diff line change
Expand Up @@ -403,7 +403,7 @@ def test_check__all__(self):
("unittest.result", "unittest.case",
"unittest.suite", "unittest.loader",
"unittest.main", "unittest.runner",
"unittest.signals"),
"unittest.signals", "unittest.async_case"),
extra=extra,
blacklist=blacklist)

Expand Down
3 changes: 2 additions & 1 deletion Lib/unittest/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def testMultiply(self):
SUPPORT, UPDATES, ENHANCEMENTS, OR MODIFICATIONS.
"""

__all__ = ['TestResult', 'TestCase', 'TestSuite',
__all__ = ['TestResult', 'TestCase', 'AsyncioTestCase', 'TestSuite',
'TextTestRunner', 'TestLoader', 'FunctionTestCase', 'main',
'defaultTestLoader', 'SkipTest', 'skip', 'skipIf', 'skipUnless',
'expectedFailure', 'TextTestResult', 'installHandler',
Expand All @@ -57,6 +57,7 @@ def testMultiply(self):
__unittest = True

from .result import TestResult
from .async_case import AsyncioTestCase
from .case import (addModuleCleanup, TestCase, FunctionTestCase, SkipTest, skip,
skipIf, skipUnless, expectedFailure)
from .suite import BaseTestSuite, TestSuite
Expand Down
127 changes: 127 additions & 0 deletions Lib/unittest/async_case.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
import asyncio
import inspect

from .case import TestCase



class AsyncioTestCase(TestCase):
# Names intentionally have a long prefix
# to reduce a chance of clashing with user-defined attributes
# from inherited test case
#
# The class doesn't call loop.run_until_complete(self.setUp()) and family
# but uses a different approach:
# 1. create a long-running task that reads self.setUp()
# awaitable from queue along with a future
# 2. await the awaitable object passing in and set the result
# into the future object
# 3. Outer code puts the awaitable and the future object into a queue
# with waiting for the future
# The trick is necessary because every run_until_complete() call
# creates a new task with embedded ContextVar context.
# To share contextvars between setUp(), test and tearDown() we need to execute
# them inside the same task.

# Note: the test case modifies event loop policy if the policy was not instantiated
# yet.
# asyncio.get_event_loop_policy() creates a default policy on demand but never
# returns None
# I believe this is not an issue in user level tests but python itself for testing
# should reset a policy in every test module
# by calling asyncio.set_event_loop_policy(None) in tearDownModule()

def __init__(self, methodName='runTest'):
super().__init__(methodName)
self._asyncioTestLoop = None
self._asyncioCallsQueue = None

def _callSetUp(self):
self._callMaybeAsync(self.setUp)

def _callTestMethod(self, method):
self._callMaybeAsync(method)

def _callTearDown(self):
self._callMaybeAsync(self.tearDown)

def _callCleanup(self, function, *args, **kwargs):
self._callMaybeAsync(function, *args, **kwargs)

def _callMaybeAsync(self, func, /, *args, **kwargs):
assert self._asyncioTestLoop is not None
ret = func(*args, **kwargs)
if inspect.isawaitable(ret):
fut = self._asyncioTestLoop.create_future()
self._asyncioCallsQueue.put_nowait((fut, ret))
return self._asyncioTestLoop.run_until_complete(fut)
else:
return ret

async def _asyncioLoopRunner(self):
queue = self._asyncioCallsQueue
while True:
query = await queue.get()
queue.task_done()
if query is None:
return
fut, awaitable = query
try:
ret = await awaitable
if not fut.cancelled():
fut.set_result(ret)
except asyncio.CancelledError:
raise
except Exception as ex:
if not fut.cancelled():
fut.set_exception(ex)

def _setupAsyncioLoop(self):
assert self._asyncioTestLoop is None
loop = asyncio.new_event_loop()
asyncio.set_event_loop(loop)
loop.set_debug(True)
self._asyncioTestLoop = loop
self._asyncioCallsQueue = asyncio.Queue(loop=loop)
self._asyncioCallsTask = loop.create_task(self._asyncioLoopRunner())

def _tearDownAsyncioLoop(self):
assert self._asyncioTestLoop is not None
loop = self._asyncioTestLoop
self._asyncioTestLoop = None
self._asyncioCallsQueue.put_nowait(None)
loop.run_until_complete(self._asyncioCallsQueue.join())

try:
# cancel all tasks
to_cancel = asyncio.all_tasks(loop)
if not to_cancel:
return

for task in to_cancel:
task.cancel()

loop.run_until_complete(
asyncio.gather(*to_cancel, loop=loop, return_exceptions=True))

for task in to_cancel:
if task.cancelled():
continue
if task.exception() is not None:
loop.call_exception_handler({
'message': 'unhandled exception during test shutdown',
'exception': task.exception(),
'task': task,
})
# shutdown asyncgens
loop.run_until_complete(loop.shutdown_asyncgens())
finally:
asyncio.set_event_loop(None)
loop.close()

def run(self, result=None):
self._setupAsyncioLoop()
try:
return super().run(result)
finally:
self._tearDownAsyncioLoop()
20 changes: 16 additions & 4 deletions Lib/unittest/case.py
Original file line number Diff line number Diff line change
Expand Up @@ -645,6 +645,18 @@ def _addUnexpectedSuccess(self, result):
else:
addUnexpectedSuccess(self)

def _callSetUp(self):
self.setUp()

def _callTestMethod(self, method):
method()

def _callTearDown(self):
self.tearDown()

def _callCleanup(self, function, /, *args, **kwargs):
function(*args, **kwargs)

def run(self, result=None):
orig_result = result
if result is None:
Expand Down Expand Up @@ -676,14 +688,14 @@ def run(self, result=None):
self._outcome = outcome

with outcome.testPartExecutor(self):
self.setUp()
self._callSetUp()
if outcome.success:
outcome.expecting_failure = expecting_failure
with outcome.testPartExecutor(self, isTest=True):
testMethod()
self._callTestMethod(testMethod)
outcome.expecting_failure = False
with outcome.testPartExecutor(self):
self.tearDown()
self._callTearDown()

self.doCleanups()
for test, reason in outcome.skipped:
Expand Down Expand Up @@ -721,7 +733,7 @@ def doCleanups(self):
while self._cleanups:
function, args, kwargs = self._cleanups.pop()
with outcome.testPartExecutor(self):
function(*args, **kwargs)
self._callCleanup(function, *args, **kwargs)

# return this for backwards compatibility
# even though we no longer use it internally
Expand Down
151 changes: 151 additions & 0 deletions Lib/unittest/test/test_async_case.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,151 @@
import asyncio
import unittest


def tearDownModule():
asyncio.set_event_loop_policy(None)


class TestAsyncCase(unittest.TestCase):
def test_basic(self):
events = []

class Test(unittest.AsyncioTestCase):
async def setUp(self):
self.assertEqual(events, [])
events.append('setUp')

async def test_func(self):
self.assertEqual(events, ['setUp'])
events.append('test')
self.addCleanup(self.on_cleanup)

async def tearDown(self):
self.assertEqual(events, ['setUp', 'test'])
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One of the problems I can see happening here is multiple inheritance of tests cases with both "async" and "sync" versions of "tearDown".

  • How are you supposed to call super().tearDown() in such case?
  • Is this a serious problem? I think it might be, essentially we're breaking the cooperative nature of super().
  • Should we prefix all "async" hooks, e.g. "async def asyncTearDown"? Or is that too ugly?

events.append('tearDown')

async def on_cleanup(self):
self.assertEqual(events, ['setUp', 'test', 'tearDown'])
events.append('cleanup')

test = Test("test_func")
test.run()
self.assertEqual(events, ['setUp', 'test', 'tearDown', 'cleanup'])


def test_exception_in_setup(self):
events = []

class Test(unittest.AsyncioTestCase):
async def setUp(self):
events.append('setUp')
raise Exception()

async def test_func(self):
events.append('test')
self.addCleanup(self.on_cleanup)

async def tearDown(self):
events.append('tearDown')

async def on_cleanup(self):
events.append('cleanup')


test = Test("test_func")
test.run()
self.assertEqual(events, ['setUp'])


def test_exception_in_test(self):
events = []

class Test(unittest.AsyncioTestCase):
async def setUp(self):
events.append('setUp')

async def test_func(self):
events.append('test')
raise Exception()
self.addCleanup(self.on_cleanup)

async def tearDown(self):
events.append('tearDown')

async def on_cleanup(self):
events.append('cleanup')

test = Test("test_func")
test.run()
self.assertEqual(events, ['setUp', 'test', 'tearDown'])

def test_exception_in_test_after_adding_cleanup(self):
events = []

class Test(unittest.AsyncioTestCase):
async def setUp(self):
events.append('setUp')

async def test_func(self):
events.append('test')
self.addCleanup(self.on_cleanup)
raise Exception()

async def tearDown(self):
events.append('tearDown')

async def on_cleanup(self):
events.append('cleanup')

test = Test("test_func")
test.run()
self.assertEqual(events, ['setUp', 'test', 'tearDown', 'cleanup'])

def test_exception_in_tear_down(self):
events = []

class Test(unittest.AsyncioTestCase):
async def setUp(self):
events.append('setUp')

async def test_func(self):
events.append('test')
self.addCleanup(self.on_cleanup)

async def tearDown(self):
events.append('tearDown')
raise Exception()

async def on_cleanup(self):
events.append('cleanup')

test = Test("test_func")
test.run()
self.assertEqual(events, ['setUp', 'test', 'tearDown', 'cleanup'])


def test_exception_in_tear_clean_up(self):
events = []

class Test(unittest.AsyncioTestCase):
async def setUp(self):
events.append('setUp')

async def test_func(self):
events.append('test')
self.addCleanup(self.on_cleanup)

async def tearDown(self):
events.append('tearDown')

async def on_cleanup(self):
events.append('cleanup')
raise Exception()

test = Test("test_func")
test.run()
self.assertEqual(events, ['setUp', 'test', 'tearDown', 'cleanup'])


if __name__ == "__main__":
unittest.main()