bpo-28787: Fix out of tree --with-dtrace builds #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstinner
requested changes
May 5, 2017
Makefile.pre.in
Outdated
| @@ -880,6 +880,7 @@ Python/frozen.o: Python/importlib.h Python/importlib_external.h | |||
| # follow our naming conventions. dtrace(1) uses the output filename to generate | |||
| # an include guard, so we can't use a pipeline to transform its output. | |||
| Include/pydtrace_probes.h: $(srcdir)/Include/pydtrace.d | |||
| @$(MKDIR_P) Include | |||
There was a problem hiding this comment.
Please remove @, I like to see what is done.
|
Please rebase also your change. |
stratakis
force-pushed
the
out_of_tree_dtrace
branch
from
845b707 to
fea9af6
Compare
vstinner
approved these changes
May 10, 2017
|
I merged your change, thanks @stratakis. Would you mind to backport the change? Only 3.6 is needed according to http://bugs.python.org/issue28787 I used the following commands. Without the change, make fails. With the fix, make works as expected. |
stratakis
added a commit
to stratakis/cpython
that referenced
this pull request
May 11, 2017
* bpo-28787: Fix out of tree --with-dtrace builds * Unsilence directory creation * Add Misc/NEWS and Misc/ACKS entries. (cherry picked from commit f6eae5b)
vstinner
pushed a commit
that referenced
this pull request
May 11, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Oct 10, 2017
This commit reveals a reference leak. See issue python#135, stackless-dev#135
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Oct 10, 2017
Fix several problems related with slp_prepare_slots(): - set Py_TPFLAGS_HAVE_STACKLESS_EXTENSION in slp_prepare_slots(). - for heap types free the allocated buffer in tp_dealloc - Allocate the memory from the object domain, because the blocks are small (about 74 bytes).
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Oct 29, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Jun 19, 2018
Fix several problems related with slp_prepare_slots(): - set Py_TPFLAGS_HAVE_STACKLESS_EXTENSION in slp_prepare_slots(). - for heap types free the allocated buffer in tp_dealloc - Allocate the memory from the object domain, because the blocks are small (about 74 bytes). (cherry picked from commit e217840)
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
This was referenced Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reported at: https://bugs.python.org/issue28787
This was observed after DTrace and Systemtap support was introduced for Python 3.6.0: https://bugs.python.org/issue21590