gh-136616: Improve assert syntax error messages
#136653
Merged
+594
−400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablogsal
reviewed
Jul 14, 2025
|
lysnikolaou
reviewed
Jul 15, 2025
Grammar/python.gram
Outdated
Comment on lines
1308
to
1312
| | 'assert' expression ',' a=expression '=' b=expression { | ||
| RAISE_SYNTAX_ERROR_KNOWN_RANGE( | ||
| a, b, | ||
| "cannot assign to %s here. Maybe you meant '==' instead of '='?", | ||
| _PyPegen_get_expr_name(a)) } |
There was a problem hiding this comment.
Is the second alternative here needed in reality. If someone's using the second argument here and have a comparison there, maybe they're confused and meant something completely different?
There was a problem hiding this comment.
Hm, good question. They might. For example, assert some.method() == other.method(), some == other might be a realiastic case. But, I am open to other opinions :)
This is a bit annoying. I opened #136680 to fix this. |
|
@pablogsal @lysnikolaou friendly ping :) |
lysnikolaou
approved these changes
Sep 9, 2025
|
Thanks! I will wait for a week or so for @pablogsal's review. And merge it or address comments and merge it :) |
|
🛼 rolling! Thanks! :) |
lkollar
pushed a commit
to lkollar/cpython
that referenced
this pull request
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Local testing of positions and code highlight:
assertdoes not have=->==suggestion #136616