Skip to content

gh-138716: Fix assert a := b syntax error message #138718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 10, 2025
Merged

gh-138716: Fix assert a := b syntax error message #138718

merged 1 commit into from
Sep 10, 2025
+262 −173

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Sep 9, 2025 •
edited
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 9, 2025
Closed
lysnikolaou
lysnikolaou approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for following up and opening this @sobolevn!

vstinner
vstinner approved these changes Sep 10, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice enhancement.

@sobolevn sobolevn merged commit cf8f36f into python:main Sep 10, 2025
49 checks passed
@sobolevn
Copy link
Member Author

Thanks for your reviews! 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sobolevn @vstinner @lysnikolaou