Skip to content

bpo-37836: support .as_integer_ratio() in Fraction #15327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 4 commits into from
Closed

bpo-37836: support .as_integer_ratio() in Fraction #15327

wants to merge 4 commits into from

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Aug 18, 2019 •
edited by bedevere-bot
Loading

When constructing instances of fractions.Fraction, the given numerator
and denominator may now be any objects with an as_integer_ratio() method.

CC @serhiy-storchaka , @rhettinger

https://bugs.python.org/issue37836

@jdemeyer
bpo-37836: support .as_integer_ratio() in Fraction
2fe964f 
When constructing instances of fractions.Fraction, the given numerator
and denominator may now be any objects with an as_integer_ratio() method.
@jdemeyer jdemeyer mentioned this pull request Aug 19, 2019
Closed
@aeros aeros added the type-feature A feature request or enhancement label Aug 22, 2019
epicfaace
epicfaace suggested changes Aug 23, 2019
View reviewed changes
@jdemeyer @epicfaace
bpo-37836: detail in NEWS
d230396 
Co-Authored-By: Ashwin Ramaswami <aramaswamis@gmail.com>
@rhettinger
Copy link
Contributor

I believe we're decided that no one needs this and that it may even be hazardous — especially when accepting Fraction(2.5, 4.5) when the entire point of the fractions module is to achieve exactness by working with integer arithmetic.

@rhettinger rhettinger closed this Apr 20, 2022
@serhiy-storchaka
Copy link
Member

I concur with @rhettinger.

I am even think that if Fraction() is called with two arguments, both of them must be integers. But the ship is already sailed, and I am not want to argue about deprecating the current behavior (accepting Rationals).

@jdemeyer jdemeyer mentioned this pull request Apr 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aeros aeros aeros left review comments

@epicfaace epicfaace epicfaace approved these changes

Assignees
No one assigned
Labels
awaiting core review type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jdemeyer @rhettinger @serhiy-storchaka @epicfaace @aeros @the-knights-who-say-ni @bedevere-bot