Skip to content

bpo-37836: document as_integer_ratio() in the data model #15328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jdemeyer
Copy link
Contributor

@jdemeyer jdemeyer commented Aug 18, 2019

@rhettinger
Copy link
Contributor

You should get Guido to opine on this. I think you're making this more official and pervasive and prescriptive than he intended.

There is a difference between making a helpful utility available versus trying to make everyone change their code to use it.

@rhettinger rhettinger requested a review from gvanrossum August 19, 2019 00:35
@jdemeyer
Copy link
Contributor Author

I made this a draft PR since the doc says

This is used for conversion to :class:`fractions.Fraction`

but this is not yet true at the moment. So it depends on either #15327 (by me) or #15329 (by @serhiy-storchaka).

@jdemeyer jdemeyer marked this pull request as ready for review August 21, 2019 09:33
@AA-Turner
Copy link
Member

The linked issue was closed (#82017 (comment)) -- should this PR remain?

A

@gvanrossum
Copy link
Member

Let's close it, since everything else related to this was closed.

@gvanrossum gvanrossum closed this Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants