Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.7] bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) #16114

Merged
merged 1 commit into from
Sep 13, 2019

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Sep 13, 2019

https://bugs.python.org/issue34706

Specifically in the case of a class that does not override its
constructor signature inherited from object.

These are Buck Evan @bukzor's changes cherrypicked from GH-9344.
(cherry picked from commit 5b9ff7a)

Co-authored-by: Gregory P. Smith greg@krypto.org

https://bugs.python.org/issue34706

…ythonGH-16108)

https://bugs.python.org/issue34706

Specifically in the case of a class that does not override its
constructor signature inherited from object.

These are Buck Evan @bukzor's changes cherrypicked from pythonGH-9344.
(cherry picked from commit 5b9ff7a)

Co-authored-by: Gregory P. Smith <greg@krypto.org>
@miss-islington
Copy link
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor Author

@gpshead: Status check is done, and it's a success ✅ .

@matrixise matrixise merged commit 3906920 into python:3.7 Sep 13, 2019
@miss-islington miss-islington deleted the backport-5b9ff7a-3.7 branch September 13, 2019 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants