bpo-34706: Preserve subclassing in Signature.from_callable #9344

bukzor · 2018-09-16T21:14:56Z

https://bugs.python.org/issue34706

Specifically in the case of a class that does not override its constructor signature inherited from object.

https://bugs.python.org/issue34706

the-knights-who-say-ni · 2018-09-16T21:14:59Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

1st1 · 2018-09-16T23:40:16Z

Please add a NEWS entry and I'll merge this. Thanks!

serhiy-storchaka

Is this a bug fix or adding a new feature? In the former case it should be backported to older Python versions. In the latter case it needs a versionchanged directive in the documentation.

serhiy-storchaka · 2018-09-17T07:20:36Z

Lib/test/test_inspect.py

+        class MySignature(inspect.Signature): pass
+        class foo: pass
+        foo_sig = MySignature.from_callable(foo)
+        self.assertTrue(isinstance(foo_sig, MySignature))


Use assertIsinstance().

This is the style used in this file. AssertIsinstance is not used at all. Shall I change the rest of the file or only this line? Such cleanup may be better as a separate PR.

we use the more modern assertion methods when writing new code. don't worry about the rest of the file.

bukzor · 2018-09-22T16:14:24Z

Please add a NEWS entry and I'll merge this. Thanks!

I did see that notice, but couldn't figure out what to write, or whether this change is notable.
I was hoping that a maintainer would add it to my PR, since I've allowed edits.

What should the NEWS entry say? "Preserve subclassing in Signature.from_callable" ?

pythonGH-15522) https://bugs.python.org/issue22347

Modify the wheel event handler so it can also be used for module, path, and stack browsers. Patch by George Zhang.

It should avoid dynamic lookup including `isinstance`. This is a regression caused by pythonGH-5351.

* Remove implementation for old plistlib API deprecated in 3.4

Add flag -k to pathscript.py script: preserve shebang flags.

https://bugs.python.org/issue36797

) * Rename PyThreadState_DeleteCurrent() to _PyThreadState_DeleteCurrent() * Move it to the internal C API Co-Authored-By: Carol Willing <carolcode@willingconsulting.com>

If Python is installed, skip test_tools.test_pathfix test because Tools/scripts/pathfix.py script is not installed.

…-15710)

Remove PyGen_NeedsFinalizing(): it was not documented, tested or used anywhere within CPython after the implementation of PEP 442.

Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.

…thonGH-15479)

It looks like they are unused since 87cf220.

the-knights-who-say-ni · 2019-09-13T13:58:36Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@mrkn

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

gpshead · 2019-09-13T13:58:58Z

my push failed to do the right thing, i'll re-create this PR.

@bukzor

…H-16108) https://bugs.python.org/issue34706 Specifically in the case of a class that does not override its constructor signature inherited from object. These are Buck Evan @bukzor's changes cherrypicked from GH-9344.

@bukzor

…ythonGH-16108) https://bugs.python.org/issue34706 Specifically in the case of a class that does not override its constructor signature inherited from object. These are Buck Evan @bukzor's changes cherrypicked from pythonGH-9344. (cherry picked from commit 5b9ff7a) Co-authored-by: Gregory P. Smith <greg@krypto.org>

@bukzor

…H-16108) (GH-16113) https://bugs.python.org/issue34706 Specifically in the case of a class that does not override its constructor signature inherited from object. These are Buck Evan @bukzor's changes cherrypicked from GH-9344. (cherry picked from commit 5b9ff7a) Co-authored-by: Gregory P. Smith <greg@krypto.org>

@bukzor

…H-16108) (GH-16114) https://bugs.python.org/issue34706 Specifically in the case of a class that does not override its constructor signature inherited from object. These are Buck Evan @bukzor's changes cherrypicked from GH-9344. (cherry picked from commit 5b9ff7a) Co-authored-by: Gregory P. Smith <greg@krypto.org>

the-knights-who-say-ni added the CLA not signed label Sep 16, 2018

bedevere-bot added the awaiting review label Sep 16, 2018

the-knights-who-say-ni added CLA signed and removed CLA not signed labels Sep 16, 2018

1st1 approved these changes Sep 16, 2018

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Sep 16, 2018

asottile approved these changes Sep 17, 2018

View reviewed changes

serhiy-storchaka reviewed Sep 17, 2018

View reviewed changes

terryjreedy and others added 18 commits September 4, 2019 20:20

Fix idlelib.help comments (pythonGH-15669)

6cd9666

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs (

87bd207

pythonGH-15522) https://bugs.python.org/issue22347

bpo-37902: IDLE: Add scrolling for IDLE browsers. (python#15368)

2cd9025

Modify the wheel event handler so it can also be used for module, path, and stack browsers. Patch by George Zhang.

bpo-38026: fix inspect.getattr_static (pythonGH-15676)

8f9cc87

It should avoid dynamic lookup including `isinstance`. This is a regression caused by pythonGH-5351.

bpo-36324: Apply review comments from Allen Downey (pythonGH-15693)

e4810b2

bpo-36324: Apply review comment from Jake Vanderplas (pythonGH-15695)

9b51570

bpo-36409: Remove old plistlib API deprecated in 3.4 (pythonGH-15615)

ce81a92

* Remove implementation for old plistlib API deprecated in 3.4

Correct minor gramatical mistake in sys.settrace doc (pythonGH-15637)

3038e87

bpo-37064: Add option -k to Tools/scripts/pathfix.py (pythonGH-15548)

50254ac

Add flag -k to pathscript.py script: preserve shebang flags.

bpo-36797: Fix a dead link in Doc/distutils/apiref (pythonGH-15700)

2c2b561

https://bugs.python.org/issue36797

bpo-37878: Remove PyThreadState_DeleteCurrent() function (pythonGH-15315

2bc43cd

) * Rename PyThreadState_DeleteCurrent() to _PyThreadState_DeleteCurrent() * Move it to the internal C API Co-Authored-By: Carol Willing <carolcode@willingconsulting.com>

bpo-37064: Skip test_tools.test_pathfix if installed (pythonGH-15705)

3f43cef

If Python is installed, skip test_tools.test_pathfix test because Tools/scripts/pathfix.py script is not installed.

replace inline function is_small_int with a macro version (pythonGH…

6b51998

…-15710)

More refinements to the statistics docs (pythonGH-15713)

d8c93aa

bpo-15088 : Remove PyGen_NeedsFinalizing() (pythonGH-15702)

74b662c

Remove PyGen_NeedsFinalizing(): it was not documented, tested or used anywhere within CPython after the implementation of PEP 442.

bpo-38041: Refine IDLE Shell restart lines. (pythonGH-15709)

38da805

Restart lines now always start with '=' and never end with ' ' and fill the width of the window unless that would require ending with ' ', which could be wrapped by itself and possible confusing the user.

bpo-20806: Reference both times(2) and times(3) and link to MSDN. (py…

3ccdbc3

…thonGH-15479)

Remove some unused defines in multiprocessing.h. (pythonGH-15661)

32f8253

It looks like they are unused since 87cf220.

bukzor requested review from ncoghlan, pablogsal, pganssle, rhettinger, skrah, terryjreedy, tiran, warsaw and a team as code owners September 13, 2019 13:58

the-knights-who-say-ni added CLA not signed and removed CLA signed labels Sep 13, 2019

gpshead closed this Sep 13, 2019

gpshead mentioned this pull request Sep 13, 2019

bpo-34706: Preserve subclassing in inspect.Signature.from_callable #16108

Merged

pganssle removed request for a team, abalkin, pganssle, terryjreedy and ezio-melotti September 13, 2019 15:56

This was referenced Sep 13, 2019

[3.8] bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) #16113

Merged

[3.7] bpo-34706: Preserve subclassing in inspect.Signature.from_callable (GH-16108) #16114

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bpo-34706: Preserve subclassing in Signature.from_callable #9344

bpo-34706: Preserve subclassing in Signature.from_callable #9344

bukzor commented Sep 16, 2018 •

edited by bedevere-bot

Loading

the-knights-who-say-ni commented Sep 16, 2018

1st1 commented Sep 16, 2018

serhiy-storchaka left a comment

serhiy-storchaka Sep 17, 2018

bukzor Sep 22, 2018

gpshead Sep 13, 2019

bukzor commented Sep 22, 2018

the-knights-who-say-ni commented Sep 13, 2019

gpshead commented Sep 13, 2019

bpo-34706: Preserve subclassing in Signature.from_callable #9344

bpo-34706: Preserve subclassing in Signature.from_callable #9344

Conversation

bukzor commented Sep 16, 2018 • edited by bedevere-bot Loading

the-knights-who-say-ni commented Sep 16, 2018

1st1 commented Sep 16, 2018

serhiy-storchaka left a comment

Choose a reason for hiding this comment

serhiy-storchaka Sep 17, 2018

Choose a reason for hiding this comment

bukzor Sep 22, 2018

Choose a reason for hiding this comment

gpshead Sep 13, 2019

Choose a reason for hiding this comment

bukzor commented Sep 22, 2018

the-knights-who-say-ni commented Sep 13, 2019

CLA Missing

gpshead commented Sep 13, 2019

bukzor commented Sep 16, 2018 •

edited by bedevere-bot

Loading