-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bpo-41730: Show deprecation warnings for tkinter.tix #22186
Conversation
All tests have passed. Now it's time to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Good spot with the example (lines 16 + 17) 👍
-
Your PR still shows in issue 41370
-
The doc (https://docs.python.org/3/library/tkinter.tix.html) states "This Tk extension is unmaintained and should not be used in new code.".
Apologies, I missed that.
Suggested by @E-Paine Co-authored-by: E-Paine <63801254+E-Paine@users.noreply.github.com>
Has been removed from bpo-41370. Thanks! |
Um... Not sure if this is because of bedevere on your last comment, but it has reappeared there (may just be worth leaving it for someone else to sort out...) |
😓 |
It appears so 😄 (EDIT: Appears like its fixed rather than its still there - sorry for the lack of clarity) |
This comment has been minimized.
This comment has been minimized.
🆗! Thanks! |
IMO the tracker shouldn't link again if it was unlinked before 😄 |
Um, is there any further process on this? |
Misc/NEWS.d/next/Library/2020-09-10-07-23-24.bpo-41730.DyKFi9.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
Co-authored-by: Zachary Ware <zachary.ware@gmail.com>
Thanks for making the requested changes! @zware: please review the changes made to this pull request. |
Thanks for making the requested changes! @zware: please review the changes made to this pull request. |
You also need to change line 32 to use import_helper |
I believe we should keep the |
Actually, it was redundant where it was. So we should probably move it before the main tkinter import or remove it (as you have done). |
GH-25971 is a backport of this pull request to the 3.10 branch. |
Unfortunately this commit has introduced some reference leaks, see: https://buildbot.python.org/all/#/builders/684/builds/5 @zware could you take a look? |
Added in bpo-41730 (pythonGH-22186), the test apparently causes refleaks. The test isn't worth hunting them down, so it's simply reverted. This partially reverts commit 4a2d98a.
Ah, you mean https://buildbot.python.org/all/#/builders/511/builds/23 :). The test isn't worthwhile; I've opened GH-26005 to revert it. |
Added in bpo-41730 (pythonGH-22186), the test apparently causes refleaks. The test isn't worth hunting them down, so it's simply reverted. This partially reverts commit 4a2d98a. (cherry picked from commit 8e8307d) Co-authored-by: Zachary Ware <zach@python.org>
My bad! I copied the wrong url :( |
The
tkinter.tix
module has been deprecated since Python 3.6. Warn aDeprecationWarning
when importing it.https://bugs.python.org/issue41730