Skip to content

Revert test for Tix deprecation warning #26005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2021
Merged

Revert test for Tix deprecation warning #26005

merged 1 commit into from
May 9, 2021

Conversation

zware
Copy link
Member

@zware zware commented May 9, 2021 •
edited by miss-islington
Loading

Added in bpo-41730 (GH-22186), the test apparently causes refleaks. The
test isn't worth hunting them down, so it's simply reverted.

This partially reverts commit 4a2d98a.

@zware
Revert test for Tix deprecation warning
0d31057 
Added in bpo-41730 (pythonGH-22186), the test apparently causes refleaks.  The
test isn't worth hunting them down, so it's simply reverted.

This partially reverts commit 4a2d98a.
@zware zware self-assigned this May 9, 2021
@zware zware requested a review from pablogsal May 9, 2021 06:44
@zware zware mentioned this pull request May 9, 2021
Merged
@zware zware merged commit 8e8307d into python:main May 9, 2021
@zware zware deleted the revert_tix_deprecation_test branch May 9, 2021 06:58
@miss-islington
Copy link
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @zware, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 8e8307d70bb9dc18cfeeed3277c076309b27515e 3.10

@zware zware added needs backport to 3.10 only security fixes and removed needs backport to 3.10 only security fixes labels May 9, 2021
@miss-islington
Copy link
Contributor

Thanks @zware for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-26006 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 9, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 9, 2021
@zware @miss-islington
Revert test for Tix deprecation warning (pythonGH-26005)
a7e148d 
Added in bpo-41730 (pythonGH-22186), the test apparently causes refleaks.  The
test isn't worth hunting them down, so it's simply reverted.

This partially reverts commit 4a2d98a.
(cherry picked from commit 8e8307d)

Co-authored-by: Zachary Ware <zach@python.org>
miss-islington added a commit that referenced this pull request May 9, 2021
@miss-islington @zware
Revert test for Tix deprecation warning (GH-26005)
c3eb3c1 
Added in bpo-41730 (GH-22186), the test apparently causes refleaks.  The
test isn't worth hunting them down, so it's simply reverted.

This partially reverts commit 4a2d98a.
(cherry picked from commit 8e8307d)

Co-authored-by: Zachary Ware <zach@python.org>
@pablogsal
Copy link
Member

Thanks @zware !

@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

@zware zware

Labels
skip issue skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zware @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni