Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-42257: handle empty string in variable executable in platform.libc_ver() #23140

Merged
merged 1 commit into from
Jan 2, 2021

Conversation

kurochan
Copy link
Contributor

@kurochan kurochan commented Nov 4, 2020

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@kurochan

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@kurochan
Copy link
Contributor Author

Can anyone review this PR? 🤔

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@malemburg
Copy link
Member

The patch looks good. Could you please also add a NEWS entry ?

@malemburg
Copy link
Member

The nntplib test fails, preventing a merge. This doesn't seem to be related to this PR, so I guess we'll have to wait and then rebase the PR after this is fixed in the master branch.

@malemburg
Copy link
Member

@kurochan Could you please rebase the PR. The nntplib issue (#24037) should be resolved now.

@malemburg malemburg merged commit d914283 into python:master Jan 2, 2021
@bedevere-bot
Copy link

@malemburg: Please replace # with GH- in the commit message next time. Thanks!

@malemburg
Copy link
Member

Thanks for the patch @kurochan.

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants