Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42794: Update test_nntplib to use offical group name for testing #24037

Merged
merged 2 commits into from
Jan 1, 2021
Merged

bpo-42794: Update test_nntplib to use offical group name for testing #24037

merged 2 commits into from
Jan 1, 2021

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Jan 1, 2021 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jan 1, 2021
@corona10
Copy link
Member Author

corona10 commented Jan 1, 2021

I add the backport label for 3.7 and 3.6 also.
We often send backport patches for security issues but this issue breaks 3.7 and 3.6 testing also.
If there are other opinions please let me know.

@malemburg
Copy link
Member

Patch looks good.

malemburg
malemburg reviewed Jan 1, 2021
View reviewed changes
Lib/test/test_nntplib.py
@@ -343,8 +344,9 @@ class NetworkedNNTP_SSLTests(NetworkedNNTPTests):
# 400 connections per day are accepted from each IP address."

NNTP_HOST = 'nntp.aioe.org'
GROUP_NAME = 'comp.lang.python'
GROUP_PAT = 'comp.lang.*'
GROUP_NAME = 'aioe.test'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably a good idea to add a comment to this section, mentioning that aioe.test is one of the official groups on this server used for testing: https://news.aioe.org/manual/aioe-hierarchy/

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you add a comment, add "bpo-42794: " which always helps for future readers ;-)

vstinner
vstinner approved these changes Jan 1, 2021
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@corona10 corona10 requested a review from malemburg January 1, 2021 14:01
@corona10 corona10 merged commit ec31653 into python:master Jan 1, 2021
@miss-islington
Copy link
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7, 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-24039 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

GH-24040 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2021
@corona10 @miss-islington
bpo-42794: Update test_nntplib to use offical group name for testing (p…
a9aac21 
…ythonGH-24037)

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2021
@corona10 @miss-islington
bpo-42794: Update test_nntplib to use offical group name for testing (p…
12415b7 
…ythonGH-24037)

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@bedevere-bot
Copy link

GH-24041 is a backport of this pull request to the 3.7 branch.

@bedevere-bot
Copy link

GH-24042 is a backport of this pull request to the 3.6 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2021
@corona10 @miss-islington
bpo-42794: Update test_nntplib to use offical group name for testing (p…
2d40c62 
…ythonGH-24037)

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 1, 2021
@corona10 @miss-islington
bpo-42794: Update test_nntplib to use offical group name for testing (p…
4dc2d14 
…ythonGH-24037)

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
miss-islington added a commit that referenced this pull request Jan 1, 2021
@miss-islington @corona10
bpo-42794: Update test_nntplib to use offical group name for testing (G…
381f3e4 
…H-24037)

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
miss-islington added a commit that referenced this pull request Jan 1, 2021
@miss-islington @corona10
bpo-42794: Update test_nntplib to use offical group name for testing (G…
b20d5e5 
…H-24037)

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
ned-deily pushed a commit that referenced this pull request Jan 1, 2021
@miss-islington @corona10
bpo-42794: Update test_nntplib to use offical group name for testing (G…
8200ee6 
…H-24037) (GH-24041)

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
ned-deily pushed a commit that referenced this pull request Jan 1, 2021
@miss-islington @corona10
bpo-42794: Update test_nntplib to use offical group name for testing (G…
546baba 
…H-24037) (GH-24042)

(cherry picked from commit ec31653)

Co-authored-by: Dong-hee Na <donghee.na@python.org>
@malemburg malemburg mentioned this pull request Jan 1, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@corona10 @adorilson
bpo-42794: Update test_nntplib to use offical group name for testing (p…
bcb704a 
…ythonGH-24037)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@malemburg malemburg Awaiting requested review from malemburg

Assignees
No one assigned
Labels
tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@corona10 @malemburg @miss-islington @bedevere-bot @vstinner @the-knights-who-say-ni