Skip to content

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 #23341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 18, 2020
Merged

bpo-40956: Convert _sqlite3.Connection to Argument Clinic, part 1 of 2 #23341

merged 3 commits into from
Dec 18, 2020

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Nov 17, 2020 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Nov 17, 2020 •
edited
Loading

@corona10: As proposed on #23057, I've split that PR up in two parts. This is the first, and larger (by line count) part, however probably the easiest to review, as the AC conversion is straight-forward.

This was referenced Nov 17, 2020
Merged
Closed
@erlend-aasland
Copy link
Contributor Author

@corona10 Have you had time to look at this? Let me know if still think it's too large for a single review.

@corona10 corona10 self-requested a review December 17, 2020 10:40
@corona10
Copy link
Member

@erlend-aasland I will take a look ;)

@erlend-aasland
Copy link
Contributor Author

@corona10 Thank you :) 🙏🏻

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aasland
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

corona10
corona10 approved these changes Dec 18, 2020
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for nit comment ;)

@erlend-aasland
Copy link
Contributor Author

LGTM except for nit comment ;)

I appreciate a thorough review! :) PTAL

@corona10 corona10 merged commit 1ba82bb into python:master Dec 18, 2020
@corona10 corona10 mentioned this pull request Dec 18, 2020
Merged
@erlend-aasland erlend-aasland deleted the bpo-40956/part2a-con branch December 18, 2020 15:36
@erlend-aasland erlend-aasland mentioned this pull request Dec 30, 2020
Merged
@erlend-aasland erlend-aasland mentioned this pull request Feb 9, 2021
Closed
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@adorilson
bpo-40956: Convert _sqlite3.Connection to Argument Clinic (pythonGH-2…
7f94211 
…3341)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@corona10 corona10 corona10 approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@erlend-aasland @corona10 @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni