Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-79097: Add support for aggregate window functions in sqlite3 #20903

Merged
merged 57 commits into from
Apr 12, 2022
Merged

gh-79097: Add support for aggregate window functions in sqlite3 #20903

merged 57 commits into from
Apr 12, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 15, 2020 •
edited
Loading

Fixes #79097

@erlend-aasland
Copy link
Contributor Author

Rebased onto master and upgraded with Py_NewRef and intermingled declarations.

@erlend-aasland erlend-aasland marked this pull request as draft November 17, 2020 22:28
@erlend-aasland
Copy link
Contributor Author

On hold until #23341 is merged

@erlend-aasland erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from f39fc9f to a36a1a5 Compare December 28, 2020 11:58
@erlend-aasland erlend-aasland force-pushed the fix-issue-34916 branch 10 times, most recently from 9c27690 to b91947d Compare March 10, 2021 13:02
@erlend-aasland erlend-aasland marked this pull request as ready for review March 10, 2021 13:33
@erlend-aasland erlend-aasland mentioned this pull request Mar 10, 2021
Closed
@erlend-aasland erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from 5f17f41 to f1459ed Compare April 18, 2021 22:09
@erlend-aasland erlend-aasland force-pushed the fix-issue-34916 branch 2 times, most recently from 799bcf6 to 3f052a6 Compare April 23, 2021 09:21
Erlend E. Aasland added 3 commits April 23, 2021 11:24
Add support for sqlite3 aggregate window functions
bbef5a4 
See https://docs.python.org/3/library/exceptions.html#NotImplementedError:
It should not be used to indicate that an operator or method is not
meant to be supported at all – in that case either leave the operator /
method undefined or, if a subclass, set it to None.
Add NEWS entry
93bfb30
Add What's New
7dfeb13
@erlend-aasland
Copy link
Contributor Author

erlend-aasland commented Apr 23, 2021 •
edited
Loading

@berkerpeksag Any chance of getting this in before the feature freeze early in the 3.11 dev phase?

@erlend-aasland erlend-aasland changed the title bpo-34916: Add support for aggregate window functions in sqlite3 bpo-79097: Add support for aggregate window functions in sqlite3 Apr 10, 2022
@erlend-aasland erlend-aasland changed the title bpo-79097: Add support for aggregate window functions in sqlite3 gh-79097: Add support for aggregate window functions in sqlite3 Apr 10, 2022
@erlend-aasland erlend-aasland marked this pull request as ready for review April 10, 2022 22:14
@erlend-aasland erlend-aasland added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 340cea9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@erlend-aasland erlend-aasland added 🔨 test-with-buildbots Test PR w/ buildbots; report in status section extension-modules C modules in the Modules dir labels Apr 10, 2022
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @erlend-aasland for commit 340cea9 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Apr 10, 2022
@erlend-aasland
Copy link
Contributor Author

@JelleZijlstra, would you like to review this?

FYI, the two buildbot failures look unrelated.

@JelleZijlstra JelleZijlstra self-requested a review April 11, 2022 16:17
JelleZijlstra
JelleZijlstra reviewed Apr 11, 2022
View reviewed changes
Copy link
Member

@JelleZijlstra JelleZijlstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one requested improvement in the tests.

Let me know if there's other changes you'd like to get in in time for 3.11.

@JelleZijlstra JelleZijlstra self-assigned this Apr 11, 2022
@erlend-aasland
Copy link
Contributor Author

Let me know if there's other changes you'd like to get in in time for 3.11.

Yes, I've one more feature I'd like to get in: Blob handles, gh-30680 (currently revisiting it, hoping to make it ready for review soon).

@JelleZijlstra
Copy link
Member

Yes, I've one more feature I'd like to get in: Blob handles, gh-30680 (currently revisiting it, hoping to make it ready for review soon).

Sounds good, ping me when you're ready.

@JelleZijlstra JelleZijlstra merged commit 9ebcece into python:main Apr 12, 2022
@BigStone BigStone mannequin mentioned this pull request Apr 10, 2022
Closed
@erlend-aasland
Copy link
Contributor Author

Thanks, @JelleZijlstra! Much appreciated.

@erlend-aasland erlend-aasland deleted the fix-issue-34916 branch April 12, 2022 10:35
@JelleZijlstra JelleZijlstra mentioned this pull request Apr 15, 2022
Merged
JelleZijlstra added a commit to JelleZijlstra/typeshed that referenced this pull request Apr 15, 2022
@JelleZijlstra
sqlite3: add 3.11 additions
0ba23bb 
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
srittau pushed a commit to python/typeshed that referenced this pull request Apr 16, 2022
@JelleZijlstra
sqlite3: add 3.11 additions (#7625)
d802e65 
- Blob from python/cpython#30680 (and anticipating that python/cpython#91550 will be merged)
- Aggregate window functions from python/cpython#20903
- Serialize/deserialize from python/cpython#26728
- Limit setting from python/cpython#28463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees

@JelleZijlstra JelleZijlstra

Labels
extension-modules C modules in the Modules dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add create_window_function() to sqlite3.Connection
5 participants
@erlend-aasland @bedevere-bot @JelleZijlstra @kumaraditya303 @the-knights-who-say-ni